Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: services/navigation/navigation.h

Issue 2111353002: Move content's shell connections to the IO thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/navigation/content_client/content_browser_client.cc ('k') | services/navigation/navigation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/navigation/navigation.h
diff --git a/services/navigation/navigation.h b/services/navigation/navigation.h
index 3a731dd600e6e2440c9b8b3e640f0baae51760c6..ded2c7dbf027c329d6c0851783c175cc144870d0 100644
--- a/services/navigation/navigation.h
+++ b/services/navigation/navigation.h
@@ -5,6 +5,9 @@
#ifndef SERVICES_NAVIGATION_NAVIGATION_H_
#define SERVICES_NAVIGATION_NAVIGATION_H_
+#include "base/memory/ref_counted.h"
+#include "base/sequenced_task_runner.h"
+#include "content/public/common/connection_filter.h"
#include "mojo/public/cpp/bindings/binding_set.h"
#include "services/navigation/public/interfaces/view.mojom.h"
#include "services/shell/public/cpp/interface_factory.h"
@@ -17,7 +20,7 @@ class BrowserContext;
namespace navigation {
-class Navigation : public shell::Service,
+class Navigation : public content::ConnectionFilter,
public shell::InterfaceFactory<mojom::ViewFactory>,
public mojom::ViewFactory {
public:
@@ -25,11 +28,9 @@ class Navigation : public shell::Service,
~Navigation() override;
private:
- // shell::Service:
- void OnStart(shell::Connector* connector,
- const shell::Identity& identity,
- uint32_t instance_id) override;
- bool OnConnect(shell::Connection* connection) override;
+ // content::ConnectionFilter:
+ bool OnConnect(shell::Connection* connection,
+ shell::Connector* connector) override;
// shell::InterfaceFactory<mojom::ViewFactory>:
void Create(shell::Connection* connection,
@@ -41,6 +42,8 @@ class Navigation : public shell::Service,
void ViewFactoryLost();
+ scoped_refptr<base::SequencedTaskRunner> view_task_runner_;
+
shell::Connector* connector_ = nullptr;
std::string client_user_id_;
« no previous file with comments | « services/navigation/content_client/content_browser_client.cc ('k') | services/navigation/navigation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698