Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: content/gpu/gpu_child_thread.cc

Issue 2111353002: Move content's shell connections to the IO thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert some gpu changes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/gpu/gpu_child_thread.cc
diff --git a/content/gpu/gpu_child_thread.cc b/content/gpu/gpu_child_thread.cc
index af207abecc83bbbb6b4f90ae422748405757120e..2c36e17db8d8da9504f35a192dae2617720e8ea3 100644
--- a/content/gpu/gpu_child_thread.cc
+++ b/content/gpu/gpu_child_thread.cc
@@ -22,6 +22,7 @@
#include "content/gpu/gpu_watchdog_thread.h"
#include "content/public/common/content_client.h"
#include "content/public/common/content_switches.h"
+#include "content/public/common/mojo_shell_connection.h"
#include "content/public/gpu/content_gpu_client.h"
#include "gpu/command_buffer/service/gpu_switches.h"
#include "gpu/command_buffer/service/sync_point_manager.h"
@@ -36,6 +37,7 @@
#include "media/gpu/ipc/service/gpu_video_decode_accelerator.h"
#include "media/gpu/ipc/service/gpu_video_encode_accelerator.h"
#include "media/gpu/ipc/service/media_service.h"
+#include "services/shell/public/cpp/interface_registry.h"
#include "ui/gl/gl_implementation.h"
#include "ui/gl/gl_switches.h"
#include "ui/gl/gpu_switching_manager.h"
@@ -221,6 +223,18 @@ void GpuChildThread::Init(const base::Time& process_start_time) {
// Only set once per process instance.
process_control_.reset(new GpuProcessControlImpl());
+ GetInterfaceRegistry()->AddInterface(base::Bind(
+ &GpuChildThread::BindProcessControlRequest, base::Unretained(this)));
+
+ if (GetContentClient()->gpu()) { // NULL in tests.
+ GetContentClient()->gpu()->ExposeInterfacesToBrowser(
+ GetInterfaceRegistry());
+ }
+
+ // We don't want to process any incoming interface requests until
+ // OnInitialize() is invoked.
+ GetInterfaceRegistry()->PauseBinding();
+
if (GetContentClient()->gpu()) // NULL in tests.
GetContentClient()->gpu()->Initialize(this);
}
@@ -290,37 +304,6 @@ bool GpuChildThread::OnMessageReceived(const IPC::Message& msg) {
return false;
}
-bool GpuChildThread::OnConnect(shell::Connection* connection) {
- // Use of base::Unretained(this) is safe here because |service_registry()|
- // will be destroyed before GpuChildThread is destructed.
- connection->GetInterfaceRegistry()->AddInterface(base::Bind(
- &GpuChildThread::BindProcessControlRequest, base::Unretained(this)));
-
- if (GetContentClient()->gpu()) { // NULL in tests.
- GetContentClient()->gpu()->ExposeInterfacesToBrowser(
- connection->GetInterfaceRegistry());
- }
-
- // We don't want to process any incoming interface requests until
- // OnInitialize().
- if (!gpu_channel_manager_) {
- connection->GetInterfaceRegistry()->PauseBinding();
- resume_interface_bindings_callback_ = base::Bind(
- &shell::InterfaceRegistry::ResumeBinding,
- connection->GetInterfaceRegistry()->GetWeakPtr());
- }
-
- return true;
-}
-
-shell::InterfaceRegistry* GpuChildThread::GetInterfaceRegistryForConnection() {
- return nullptr;
-}
-
-shell::InterfaceProvider* GpuChildThread::GetInterfaceProviderForConnection() {
- return nullptr;
-}
-
void GpuChildThread::SetActiveURL(const GURL& url) {
GetContentClient()->SetActiveURL(url);
}
@@ -364,8 +347,7 @@ void GpuChildThread::StoreShaderToDisk(int32_t client_id,
}
void GpuChildThread::OnInitialize(const gpu::GpuPreferences& gpu_preferences) {
- if (!resume_interface_bindings_callback_.is_null())
- base::ResetAndReturn(&resume_interface_bindings_callback_).Run();
+ GetInterfaceRegistry()->ResumeBinding();
gpu_preferences_ = gpu_preferences;
@@ -584,7 +566,7 @@ void GpuChildThread::OnLoseAllContexts() {
}
void GpuChildThread::BindProcessControlRequest(
- mojo::InterfaceRequest<mojom::ProcessControl> request) {
+ mojom::ProcessControlRequest request) {
DVLOG(1) << "GPU: Binding ProcessControl request";
DCHECK(process_control_);
process_control_bindings_.AddBinding(process_control_.get(),

Powered by Google App Engine
This is Rietveld 408576698