Added telemetry test metric network.py.

Added telemetry test metric network.py.

To be used by https://codereview.chromium.org/191383003/.

BUG=320748
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259837

[bolian, 2014-03-25 18:20:13]

Split out from https://codereview.chromium.org/191383003/
Please take a look.

[tonyg, 2014-03-25 18:39:43]

https://codereview.chromium.org/211133004/diff/1/tools/perf/metrics/network_u...
File tools/perf/metrics/network_unittest.py (right):

https://codereview.chromium.org/211133004/diff/1/tools/perf/metrics/network_u...
tools/perf/metrics/network_unittest.py:8: from metrics import metric_unittest
This stuff has to be in this CL (or else land first).

[bolian, 2014-03-25 18:54:21]

https://codereview.chromium.org/211133004/diff/1/tools/perf/metrics/network_u...
File tools/perf/metrics/network_unittest.py (right):

https://codereview.chromium.org/211133004/diff/1/tools/perf/metrics/network_u...
tools/perf/metrics/network_unittest.py:8: from metrics import metric_unittest
ah, yes. Done.

[tonyg, 2014-03-25 19:12:33]

lgtm

[bolian, 2014-03-25 19:14:14]

The CQ bit was checked by bolian@chromium.org

[commit-bot: I haz the power, 2014-03-25 19:14:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bolian@chromium.org/211133004/90001

[commit-bot: I haz the power, 2014-03-25 20:35:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 20:35:16]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[bolian, 2014-03-25 21:17:52]

Try again. Why it cannot import BytesIO from io, is the python binary older than
2.6?

[bolian, 2014-03-25 21:17:55]

The CQ bit was checked by bolian@chromium.org

[commit-bot: I haz the power, 2014-03-25 21:18:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bolian@chromium.org/211133004/90001

[tonyg, 2014-03-25 21:21:12]

On 2014/03/25 21:17:52, bolian wrote:
> Try again. Why it cannot import BytesIO from io, is the python binary older
than
> 2.6?

We require python 2.7 on all bots.

[dtu, 2014-03-25 21:30:45]

On 2014/03/25 21:21:12, tonyg wrote:
> On 2014/03/25 21:17:52, bolian wrote:
> > Try again. Why it cannot import BytesIO from io, is the python binary older
> than
> > 2.6?
> 
> We require python 2.7 on all bots.

I know what it is. There was previously a metric named io, and though it was
removed, the old, stale pyc file may still be on the disk. So io is referring to
that module instead of the Python library io.

Also, the style of those imports is not right. We only use import for modules,
never classes. And io should be grouped in the top group.

[bolian, 2014-03-25 21:38:25]

Thanks, Dave. I changed the style for importing io.
How do we deal with the stale pyc file?

[dtu, 2014-03-26 00:22:24]

On 2014/03/25 21:38:25, bolian wrote:
> Thanks, Dave. I changed the style for importing io.
> How do we deal with the stale pyc file?

Thanks. You can commit manually or commit with NOTRY=true to bypass the check.
I also have a change in flight that will clear the stale pyc file:
https://chromiumcodereview.appspot.com/205243003/

[bolian, 2014-03-27 04:20:07]

The CQ bit was checked by bolian@chromium.org

[commit-bot: I haz the power, 2014-03-27 04:22:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bolian@chromium.org/211133004/390001

[commit-bot: I haz the power, 2014-03-27 04:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 04:23:25]

Failed to apply patch for tools/perf/metrics/timeline_unittest.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file tools/perf/metrics/timeline_unittest.py
  Hunk #1 FAILED at 4.
  Hunk #2 FAILED at 86.
  2 out of 2 hunks FAILED -- saving rejects to file
tools/perf/metrics/timeline_unittest.py.rej

Patch:       tools/perf/metrics/timeline_unittest.py
Index: tools/perf/metrics/timeline_unittest.py
diff --git a/tools/perf/metrics/timeline_unittest.py
b/tools/perf/metrics/timeline_unittest.py
index
6ed9b008cf387cffbd667cdd7ed366142f21f3c7..30e69422e22594c146be11529f9c02c0c08744d5
100644
--- a/tools/perf/metrics/timeline_unittest.py
+++ b/tools/perf/metrics/timeline_unittest.py
@@ -4,40 +4,16 @@
 
 import unittest
 
+from metrics import test_page_measurement_results
 from metrics import timeline
 from telemetry.core.timeline import bounds
 from telemetry.core.timeline import model as model_module
-from telemetry.page import page as page_module
-from telemetry.page import page_measurement_results
-from telemetry.value import scalar
-
-class TestPageMeasurementResults(
-    page_measurement_results.PageMeasurementResults):
-  def __init__(self, test):
-    super(TestPageMeasurementResults, self).__init__()
-    self.test = test
-    page = page_module.Page("http://www.google.com", {})
-    self.WillMeasurePage(page)
-
-  def GetPageSpecificValueNamed(self, name):
-    values = [value for value in self.all_page_specific_values
-         if value.name == name]
-    assert len(values) == 1, 'Could not find value named %s' % name
-    return values[0]
-
-  def AssertHasPageSpecificScalarValue(self, name, units, expected_value):
-    value = self.GetPageSpecificValueNamed(name)
-    self.test.assertEquals(units, value.units)
-    self.test.assertTrue(isinstance(value, scalar.ScalarValue))
-    self.test.assertEquals(expected_value, value.value)
-
-  def __str__(self):
-    return '\n'.join([repr(x) for x in self.all_page_specific_values])
+
 
 class LoadTimesTimelineMetric(unittest.TestCase):
   def GetResultsForModel(self, metric, model):
     metric.model = model
-    results = TestPageMeasurementResults(self)
+    results = test_page_measurement_results.TestPageMeasurementResults(self)
     tab = None
     metric.AddResults(tab, results)
     return results
@@ -86,7 +62,7 @@ class LoadTimesTimelineMetric(unittest.TestCase):
 class ThreadTimesTimelineMetricUnittest(unittest.TestCase):
   def GetResultsForModel(self, metric, model):
     metric.model = model
-    results = TestPageMeasurementResults(self)
+    results = test_page_measurement_results.TestPageMeasurementResults(self)
     tab = None
     metric.AddResults(tab, results)
     return results

[bolian, 2014-03-27 05:38:10]

The CQ bit was checked by bolian@chromium.org

[commit-bot: I haz the power, 2014-03-27 05:39:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bolian@chromium.org/211133004/410001

[commit-bot: I haz the power, 2014-03-27 11:54:06]

Change committed as 259837