Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2111323003: Turn off the auto color readability of LabelButton in non-high contrast mode (Closed)

Created:
4 years, 5 months ago by Sungmann Cho
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn off the auto color readability of LabelButton in non-high contrast mode We turn on the auto color readability of LabelButton when entering into high contrast mode, and never turn it off even after exiting the mode. This leads to wrong colored text when switching from high contrast mode to non-high contrast mode. BUG=625205 Committed: https://crrev.com/ea4e665db506d059c72cc51593888e5476eac4ac Cr-Commit-Position: refs/heads/master@{#403917}

Patch Set 1 #

Patch Set 2 : Add a test for this CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M ui/views/controls/button/label_button.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/button/label_button_unittest.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Sungmann Cho
Please take a look. Thanks!
4 years, 5 months ago (2016-07-01 17:45:12 UTC) #3
sky
How about test coverage?
4 years, 5 months ago (2016-07-01 19:42:09 UTC) #4
Sungmann Cho
On 2016/07/01 19:42:09, sky wrote: > How about test coverage? I've added a test for ...
4 years, 5 months ago (2016-07-04 03:15:26 UTC) #5
sky
LGTM
4 years, 5 months ago (2016-07-06 15:48:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111323003/20001
4 years, 5 months ago (2016-07-06 15:49:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-06 16:39:56 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 16:40:05 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 16:41:36 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea4e665db506d059c72cc51593888e5476eac4ac
Cr-Commit-Position: refs/heads/master@{#403917}

Powered by Google App Engine
This is Rietveld 408576698