Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Unified Diff: chrome/browser/media/router/mojo/media_router.mojom

Issue 2111303003: [Media Router] Replace route messaging API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/router/mojo/OWNERS ('k') | chrome/browser/media/router/mojo/media_router_mojo_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/router/mojo/media_router.mojom
diff --git a/chrome/browser/media/router/mojo/media_router.mojom b/chrome/browser/media/router/mojo/media_router.mojom
index 816527e1d1d0c9cd3d1fc8f3cc37cb230a49a85a..bbf4a3b5c53ee0779987f7cc8c78238c84c620cf 100644
--- a/chrome/browser/media/router/mojo/media_router.mojom
+++ b/chrome/browser/media/router/mojo/media_router.mojom
@@ -206,8 +206,8 @@ interface MediaRouteProvider {
// CreateRoute for additional documentation.
//
// If |timeout_millis| is positive, it will be used in place of the default
- // timeout defined by Media Route Provider Manager; see CreateRoute for additional
- // documentation.
+ // timeout defined by Media Route Provider Manager; see CreateRoute for
+ // additional documentation.
//
// If the route request was created by an off the record (incognito) profile,
// |off_the_record| must be true.
@@ -272,18 +272,15 @@ interface MediaRouteProvider {
// that being with StartObservingMediaRoutes()).
StopObservingMediaRoutes(string media_source);
- // Called when the MediaRouter is ready to get the next batch of messages
- // associated with |route_id|.
- // |messages| returned will contain the batch of messages.
- // |messages| will be empty if |StopListeningForRouteMessages| was invoked.
- // |error| indicates if a permanent error occurred. If true, then subsequent
- // calls will also return with |error| being true.
- ListenForRouteMessages(string route_id) =>
- (array<RouteMessage> messages, bool error);
+ // Starts listening for messages from the media sink for the route given by
+ // |route_id|.
+ // |MediaRouter::OnRouteMessagesReceived| will be invoked when a batch of
+ // messages arrives, or when there is an error.
+ // |StopListeningForRouteMessages| will stop the Media Router from receiving
+ // further messages for |route_id|.
+ StartListeningForRouteMessages(string route_id);
// Called when there are no more listeners for messages for |route_id|.
- // Calling this will resolve the pending |ListenForRouteMessages| callback
- // with an empty list.
StopListeningForRouteMessages(string route_id);
// Indicates that a PresentationConnection that was connected to route
@@ -374,5 +371,14 @@ interface MediaRouter {
OnPresentationConnectionClosed(
string route_id, PresentationConnectionCloseReason reason,
string message);
+
+ // Called when the a batch of messages arrives from the media sink for the
+ // route given by |route_id|.
+ // |StartListeningForRouteMessages| must be called first in order to receive
+ // messages.
+ // |route_id|: ID of route of the messages.
+ // |messages|: A non-empty list of messages received.
+ OnRouteMessagesReceived(string route_id,
+ array<RouteMessage> messages);
};
« no previous file with comments | « chrome/browser/media/router/mojo/OWNERS ('k') | chrome/browser/media/router/mojo/media_router_mojo_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698