Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2111283002: arc: Improve copy on error cases in opt-in flow (Closed)

Created:
4 years, 5 months ago by Luis Héctor Chávez
Modified:
4 years, 5 months ago
Reviewers:
mitsuji, Yusuke Sato
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Improve copy on error cases in opt-in flow Since the window can be dismissed and then reappear, the user needs more context. BUG=b/29439306 TEST=simulated a failure, saw the new strings Committed: https://crrev.com/985fa8d13b90d974960f74893010c9cbf72faaeb Cr-Commit-Position: refs/heads/master@{#403311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Luis Héctor Chávez
PTAL
4 years, 5 months ago (2016-06-30 21:27:08 UTC) #2
Yusuke Sato
rs-lgtm assuming that mitsuji@ is okay with this.
4 years, 5 months ago (2016-06-30 21:58:10 UTC) #3
Luis Héctor Chávez
On 2016/06/30 21:58:10, Yusuke Sato wrote: > rs-lgtm assuming that mitsuji@ is okay with this. ...
4 years, 5 months ago (2016-06-30 22:10:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111283002/1
4 years, 5 months ago (2016-06-30 22:11:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 22:16:13 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 22:18:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/985fa8d13b90d974960f74893010c9cbf72faaeb
Cr-Commit-Position: refs/heads/master@{#403311}

Powered by Google App Engine
This is Rietveld 408576698