Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2111263002: S390: Fix MathMaxMin's frame (Closed)

Created:
4 years, 5 months ago by john.yan
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix MathMaxMin's frame MathMaxMin creates frame on stack without removing top bit of r14 on 31-bit. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/4fa104c5f93e62ce86f773d90f020009acdda0c8 Cr-Commit-Position: refs/heads/master@{#37460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/s390/builtins-s390.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
john.yan
PTAL
4 years, 5 months ago (2016-06-30 20:51:58 UTC) #1
JaideepBajwa
lgtm
4 years, 5 months ago (2016-06-30 20:54:47 UTC) #2
JaideepBajwa
lgtm
4 years, 5 months ago (2016-06-30 20:55:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111263002/1
4 years, 5 months ago (2016-06-30 20:58:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 21:23:34 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 21:23:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fa104c5f93e62ce86f773d90f020009acdda0c8
Cr-Commit-Position: refs/heads/master@{#37460}

Powered by Google App Engine
This is Rietveld 408576698