Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2749)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 2111223002: [MD settings] set route on advanced page toggle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_main/settings_main.js
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.js b/chrome/browser/resources/settings/settings_main/settings_main.js
index f9afe10053f9bbe4649a97a3c3b9115cdebe440d..72f64d6e90054aac522215723b67881194199c12 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.js
+++ b/chrome/browser/resources/settings/settings_main/settings_main.js
@@ -69,6 +69,12 @@ Polymer({
document.addEventListener('toggle-advanced-page', function(e) {
this.showAdvancedPage_ = e.detail;
this.isAdvancedMenuOpen_ = e.detail;
+ this.currentRoute = {
+ page: this.isAdvancedMenuOpen_ ? 'advanced' : 'basic',
+ section: '',
+ subpage: [],
+ url: '',
Dan Beam 2016/06/30 23:40:26 where'd we land on omitting the url key as I asked
dschuyler 2016/07/01 00:59:05 Done.
+ };
if (this.showAdvancedPage_) {
doWhenReady(
function() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698