Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 /** | 5 /** |
| 6 * @typedef {{ | 6 * @typedef {{ |
| 7 * url: string, | 7 * dialog: (string|undefined), |
| 8 * page: string, | 8 * page: string, |
| 9 * section: string, | 9 * section: string, |
| 10 * subpage: !Array<string>, | 10 * subpage: !Array<string>, |
| 11 * dialog: (string|undefined), | 11 * url: (string|undefined), |
|
Dan Beam
2016/07/01 01:11:51
can you just remove url from this? and we make a
dschuyler
2016/07/01 22:31:22
Dan and I discussed this offline. Tommy is working
| |
| 12 * }} | 12 * }} |
| 13 */ | 13 */ |
| 14 var SettingsRoute; | 14 var SettingsRoute; |
| 15 | 15 |
| 16 /** | 16 /** |
| 17 * @fileoverview | 17 * @fileoverview |
| 18 * 'settings-router' is a simple router for settings. Its responsibilities: | 18 * 'settings-router' is a simple router for settings. Its responsibilities: |
| 19 * - Update the URL when the routing state changes. | 19 * - Update the URL when the routing state changes. |
| 20 * - Initialize the routing state with the initial URL. | 20 * - Initialize the routing state with the initial URL. |
| 21 * - Process and validate all routing state changes. | 21 * - Process and validate all routing state changes. |
| (...skipping 607 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 629 window.history.replaceState(historicState, document.title); | 629 window.history.replaceState(historicState, document.title); |
| 630 } | 630 } |
| 631 | 631 |
| 632 return; | 632 return; |
| 633 } | 633 } |
| 634 } | 634 } |
| 635 | 635 |
| 636 assertNotReached('Route not found: ' + JSON.stringify(newRoute)); | 636 assertNotReached('Route not found: ' + JSON.stringify(newRoute)); |
| 637 }, | 637 }, |
| 638 }); | 638 }); |
| OLD | NEW |