Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2111203004:
ScrollingCoordinator: On layer update, add scrollOrigin instead of subtracting minimumScrollPosition (Closed)
|
Created:
4 years, 5 months ago by Eric Seckler Modified:
4 years, 5 months ago Reviewers:
bokan CC:
chromium-reviews, blink-layers+watch_chromium.org, kenneth.christiansen, blink-reviews, Sami Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionScrollingCoordinator: On layer update, add scrollOrigin instead of subtracting minimumScrollPosition.
BUG=625084
Committed: https://crrev.com/9a591c7e2e4fca8ef2bb1d775422b3f15e55bae8
Cr-Commit-Position: refs/heads/master@{#403478}
Patch Set 1 #Patch Set 2 : Fix compilation issue. #Messages
Total messages: 25 (13 generated)
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
eseckler@chromium.org changed reviewers: + bokan@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Before committing, please shorten title to <80 chars, if you add description make sure it wraps at 80. (Our tooling should do this for you but it doesn't :( )
The CQ bit was checked by eseckler@chromium.org
The CQ bit was unchecked by eseckler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by eseckler@chromium.org
The CQ bit was unchecked by eseckler@chromium.org
Description was changed from ========== Add scrollOrigin instead of subtracting minimumScrollPosition in ScrollingCoordinator::scrollableAreaScrollLayerDidChange. BUG=625084 ========== to ========== ScrollingCoordinator: On layer update, add scrollOrigin instead of subtracting minimumScrollPosition. BUG=625084 ==========
The CQ bit was checked by eseckler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== ScrollingCoordinator: On layer update, add scrollOrigin instead of subtracting minimumScrollPosition. BUG=625084 ========== to ========== ScrollingCoordinator: On layer update, add scrollOrigin instead of subtracting minimumScrollPosition. BUG=625084 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== ScrollingCoordinator: On layer update, add scrollOrigin instead of subtracting minimumScrollPosition. BUG=625084 ========== to ========== ScrollingCoordinator: On layer update, add scrollOrigin instead of subtracting minimumScrollPosition. BUG=625084 Committed: https://crrev.com/9a591c7e2e4fca8ef2bb1d775422b3f15e55bae8 Cr-Commit-Position: refs/heads/master@{#403478} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9a591c7e2e4fca8ef2bb1d775422b3f15e55bae8 Cr-Commit-Position: refs/heads/master@{#403478} |
