Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 2111203003: Check total duration for progress bar animation (Closed)

Created:
4 years, 5 months ago by mdjones
Modified:
4 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check total duration for progress bar animation Somehow totalDuration is still becoming negative, this change puts a final check for negative values before updating the animation. BUG=622540 Committed: https://crrev.com/fe2608b05f2fa8584a810b46951c463d19b0d180 Cr-Commit-Position: refs/heads/master@{#403214}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ted C
lgtm
4 years, 5 months ago (2016-06-30 16:43:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111203003/1
4 years, 5 months ago (2016-06-30 16:44:37 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/29678)
4 years, 5 months ago (2016-06-30 16:48:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111203003/1
4 years, 5 months ago (2016-06-30 16:50:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 17:45:45 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 17:45:55 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 17:49:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe2608b05f2fa8584a810b46951c463d19b0d180
Cr-Commit-Position: refs/heads/master@{#403214}

Powered by Google App Engine
This is Rietveld 408576698