Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2111163002: Fixing MediaSessionDelegateAndroid referencing destroyed MediaSession (Closed)

Created:
4 years, 5 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing MediaSessionDelegateAndroid referencing destroyed MediaSession There's a crash caused by asynchronous audio focus events. MediaSessionDelegate may receive audio focus change signals after MediaSession::~MediaSession is called. This CL adds checks to see if the native MediaSession is destroyed before calling it's methods. BUG=624208 Committed: https://crrev.com/90dcab0540458b409b6757076ab9115789c6a5e6 Cr-Commit-Position: refs/heads/master@{#403180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/MediaSessionDelegate.java View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Zhiqiang Zhang (Slow)
4 years, 5 months ago (2016-06-30 14:00:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111163002/1
4 years, 5 months ago (2016-06-30 14:01:13 UTC) #4
mlamouri (slow - plz ping)
lgtm
4 years, 5 months ago (2016-06-30 14:06:36 UTC) #5
mlamouri (slow - plz ping)
Thank you for having a look and fixing it this fast! :)
4 years, 5 months ago (2016-06-30 14:06:59 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 15:09:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111163002/1
4 years, 5 months ago (2016-06-30 15:12:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 15:16:15 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 15:18:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90dcab0540458b409b6757076ab9115789c6a5e6
Cr-Commit-Position: refs/heads/master@{#403180}

Powered by Google App Engine
This is Rietveld 408576698