Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2111153002: [modules] Refactor parsing of anonymous declarations in default exports. (Closed)

Created:
4 years, 5 months ago by neis
Modified:
4 years, 5 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Refactor parsing of anonymous declarations in default exports. BUG= Committed: https://crrev.com/9f5f31800ea4003f9a13101ad0bc972918de21c4 Cr-Commit-Position: refs/heads/master@{#37474}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Nits and remove TODOs for now. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -89 lines) Patch
M src/ast/ast-value-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +4 lines, -7 lines 0 comments Download
M src/parsing/parser.cc View 1 13 chunks +59 lines, -80 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
neis
PTAL. This simplifies parsing of default exports. The TODOs aren't really supposed to stay in ...
4 years, 5 months ago (2016-06-30 13:49:04 UTC) #1
neis
PTAL. This simplifies parsing of default exports. The TODOs aren't really supposed to stay in ...
4 years, 5 months ago (2016-06-30 13:49:27 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111153002/1
4 years, 5 months ago (2016-06-30 14:09:29 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 14:34:32 UTC) #7
adamk
lgtm % nits and TODOs Seems like a good direction, since this better-mirrors the spec ...
4 years, 5 months ago (2016-06-30 16:30:38 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111153002/20001
4 years, 5 months ago (2016-07-01 08:40:53 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 09:17:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111153002/20001
4 years, 5 months ago (2016-07-01 09:18:28 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 09:20:33 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 09:21:47 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f5f31800ea4003f9a13101ad0bc972918de21c4
Cr-Commit-Position: refs/heads/master@{#37474}

Powered by Google App Engine
This is Rietveld 408576698