Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: ios/chrome/browser/ui/webui/history/browsing_history_handler.cc

Issue 2111103002: Make callers of FromUTC(Local)Exploded in chrome/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Lei Zhang's comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/media_galleries/picasa_album_table_reader.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/webui/history/browsing_history_handler.cc
diff --git a/ios/chrome/browser/ui/webui/history/browsing_history_handler.cc b/ios/chrome/browser/ui/webui/history/browsing_history_handler.cc
index 5b5b8d5e3989b7e34dbb92931fb82d7fa03055f5..ff0cf8ec1a277ee9f4a4f8cb2efd7ff3cc88534e 100644
--- a/ios/chrome/browser/ui/webui/history/browsing_history_handler.cc
+++ b/ios/chrome/browser/ui/webui/history/browsing_history_handler.cc
@@ -801,7 +801,11 @@ void BrowsingHistoryHandler::SetQueryTimeInMonths(
exploded.day_of_month = 1;
if (offset == 0) {
- options->begin_time = base::Time::FromLocalExploded(exploded);
+ if (!base::Time::FromLocalExploded(exploded, &options->begin_time)) {
+ // This file will be deprecated soon. No need to implement failure
+ // handling here.
+ NOTIMPLEMENTED();
+ }
// Set the end time of this first search to null (which will
// show results from the future, should the user's clock have
@@ -815,12 +819,20 @@ void BrowsingHistoryHandler::SetQueryTimeInMonths(
exploded.month -= offset - 1;
// Set the correct year.
NormalizeMonths(&exploded);
- options->end_time = base::Time::FromLocalExploded(exploded);
+ if (!base::Time::FromLocalExploded(exploded, &options->end_time)) {
+ // This file will be deprecated soon. No need to implement failure
+ // handling here.
+ NOTIMPLEMENTED();
+ }
exploded.month -= 1;
// Set the correct year
NormalizeMonths(&exploded);
- options->begin_time = base::Time::FromLocalExploded(exploded);
+ if (!base::Time::FromLocalExploded(exploded, &options->begin_time)) {
+ // This file will be deprecated soon. No need to implement failure
+ // handling here.
+ NOTIMPLEMENTED();
+ }
}
}
« no previous file with comments | « chrome/utility/media_galleries/picasa_album_table_reader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698