Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: chrome/browser/ui/webui/media/webrtc_logs_ui.cc

Issue 2111103002: Make callers of FromUTC(Local)Exploded in chrome/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Lei Zhang's comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media/webrtc_logs_ui.cc
diff --git a/chrome/browser/ui/webui/media/webrtc_logs_ui.cc b/chrome/browser/ui/webui/media/webrtc_logs_ui.cc
index e048f3ab933a960e54901f26154fdcc7fe4d4aa7..03a2524e566c3e3bb0600d48d7d9d66110931136 100644
--- a/chrome/browser/ui/webui/media/webrtc_logs_ui.cc
+++ b/chrome/browser/ui/webui/media/webrtc_logs_ui.cc
@@ -181,9 +181,12 @@ void WebRtcLogsDOMHandler::UpdateUI() {
double seconds_since_epoch;
if (base::StringToDouble(i->local_id, &seconds_since_epoch)) {
base::Time capture_time = base::Time::FromDoubleT(seconds_since_epoch);
- base::Time::Exploded lower_limit = {2012, 1, 0, 1, 0, 0, 0, 0};
- if (capture_time > base::Time::FromUTCExploded(lower_limit) &&
- capture_time < base::Time::Now()) {
+ const base::Time::Exploded lower_limit = {2012, 1, 0, 1, 0, 0, 0, 0};
+ base::Time out_time;
+ bool conversion_success =
+ base::Time::FromUTCExploded(lower_limit, &out_time);
+ DCHECK(conversion_success);
+ if (capture_time > out_time && capture_time < base::Time::Now()) {
value_w = base::TimeFormatFriendlyDateAndTime(capture_time);
}
}
« no previous file with comments | « chrome/browser/ui/webui/browsing_history_handler.cc ('k') | chrome/installer/gcapi/gcapi_omaha_experiment.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698