chrome/browser/engagement/site_engagement_service_unittest.cc - Issue 2111103002: Make callers of FromUTC(Local)Exploded in chrome/ use new time API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_service_unittest.cc

Issue 2111103002: Make callers of FromUTC(Local)Exploded in chrome/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Lei Zhang's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/engagement/site_engagement_score_unittest.cc ('k') | chrome/browser/extensions/convert_web_app_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_service_unittest.cc

diff --git a/chrome/browser/engagement/site_engagement_service_unittest.cc b/chrome/browser/engagement/site_engagement_service_unittest.cc

index a2a864b999b0d9993d74e5b5d09044e90830f7a7..3c4090089762eab40cd373dff34c6d450247f3d9 100644

--- a/chrome/browser/engagement/site_engagement_service_unittest.cc

+++ b/chrome/browser/engagement/site_engagement_service_unittest.cc

@@ -85,7 +85,10 @@ base::Time GetReferenceTime() {

exploded_reference_time.second = 0;

exploded_reference_time.millisecond = 0;

- return base::Time::FromLocalExploded(exploded_reference_time);

+ base::Time out_time;

+ EXPECT_TRUE(

+ base::Time::FromLocalExploded(exploded_reference_time, &out_time));

+ return out_time;

}

std::unique_ptr<KeyedService> BuildTestHistoryService(