chrome/installer/gcapi/gcapi_omaha_experiment.cc - Issue 2111103002: Make callers of FromUTC(Local)Exploded in chrome/ use new time API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/gcapi/gcapi_omaha_experiment.cc

Issue 2111103002: Make callers of FromUTC(Local)Exploded in chrome/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: modified comments in code Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/media/webrtc_logs_ui.cc ('K') | « chrome/browser/ui/webui/media/webrtc_logs_ui.cc ('k') | chrome/utility/media_galleries/picasa_album_table_reader.cc » ('j') | chrome/utility/media_galleries/picasa_album_table_reader.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/gcapi/gcapi_omaha_experiment.cc

diff --git a/chrome/installer/gcapi/gcapi_omaha_experiment.cc b/chrome/installer/gcapi/gcapi_omaha_experiment.cc

index 5235afd20a9a7d5a91bb68a608d3634f42f3684f..f453264386f3a0b2eedd4e677afc7c3c6d332290 100644

--- a/chrome/installer/gcapi/gcapi_omaha_experiment.cc

+++ b/chrome/installer/gcapi/gcapi_omaha_experiment.cc

@@ -20,7 +20,10 @@ namespace {

int GetCurrentRlzWeek(const base::Time& current_time) {

base::Time::Exploded february_third_2003_exploded =

Lei Zhang 2016/07/06 17:44:30 const, if you don't mind.

maksims (do not use this acc) 2016/07/07 05:48:14 Done.

Lei Zhang 2016/07/07 05:50:55 Thanks!

{2003, 2, 1, 3, 0, 0, 0, 0};

- base::Time f = base::Time::FromUTCExploded(february_third_2003_exploded);

+ base::Time f;

+ bool conversion_success =

+ base::Time::FromUTCExploded(february_third_2003_exploded, &f);

+ DCHECK(conversion_success);

base::TimeDelta delta = current_time - f;

return delta.InDays() / 7;

}