Make callers of FromUTC(Local)Exploded in chrome/ use new time API.

chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media_galleries/fileapi/picasa_file_util.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <set>
@@ skipping 82 matching lines @@
           base::StringPrintf("hello%05d.txt", i));
       if (base::WriteFile(path, NULL, 0) == -1)
         return false;
     }
 
     return true;
   }
 
   double GetVariantTimestamp() const {
     DCHECK(!folder_dir_.path().empty());
-    base::Time variant_epoch = base::Time::FromLocalExploded(
-        picasa::kPmpVariantTimeEpoch);
+    base::Time variant_epoch;
+    EXPECT_TRUE(base::Time::FromLocalExploded(picasa::kPmpVariantTimeEpoch,
+                                              &variant_epoch));
 
     int64_t microseconds_since_epoch =
         (folder_info_.timestamp - variant_epoch).InMicroseconds();
 
     return static_cast<double>(microseconds_since_epoch) /
                                base::Time::kMicrosecondsPerDay;
   }
 
   const std::set<std::string>& image_filenames() const {
     DCHECK(!folder_dir_.path().empty());
@@ skipping 265 matching lines @@
 
   scoped_refptr<storage::FileSystemContext> file_system_context_;
   std::unique_ptr<PicasaDataProvider> picasa_data_provider_;
   std::unique_ptr<MediaPathFilter> media_path_filter_;
 
   DISALLOW_COPY_AND_ASSIGN(PicasaFileUtilTest);
 };
 
 TEST_F(PicasaFileUtilTest, DateFormat) {
   base::Time::Exploded exploded_shortmonth = { 2013, 4, 0, 16, 0, 0, 0, 0 };
-  base::Time shortmonth = base::Time::FromLocalExploded(exploded_shortmonth);
+  base::Time shortmonth;
+  EXPECT_TRUE(base::Time::FromLocalExploded(exploded_shortmonth, &shortmonth));
 
   base::Time::Exploded exploded_shortday = { 2013, 11, 0, 3, 0, 0, 0, 0 };
-  base::Time shortday = base::Time::FromLocalExploded(exploded_shortday);
+  base::Time shortday;
+  EXPECT_TRUE(base::Time::FromLocalExploded(exploded_shortday, &shortday));
 
   EXPECT_EQ("2013-04-16", DateToPathString(shortmonth));
   EXPECT_EQ("2013-11-03", DateToPathString(shortday));
 }
 
 TEST_F(PicasaFileUtilTest, NameDeduplication) {
   ScopedVector<TestFolder> test_folders;
   std::vector<std::string> expected_names;
 
-  base::Time test_date = base::Time::FromLocalExploded(test_date_exploded);
+  base::Time test_date;
+  EXPECT_TRUE(base::Time::FromLocalExploded(test_date_exploded, &test_date));
   base::Time test_date_2 = test_date - base::TimeDelta::FromDays(1);
 
   std::string test_date_string = DateToPathString(test_date);
   std::string test_date_2_string = DateToPathString(test_date_2);
 
   test_folders.push_back(
       new TestFolder("diff_date", test_date_2, "uuid3", 0, 0));
   expected_names.push_back("diff_date " + test_date_2_string);
 
   test_folders.push_back(
@@ skipping 51 matching lines @@
   ScopedVector<TestFolder> empty_folders_list;
   SetupFolders(&empty_folders_list, std::vector<AlbumInfo>(), AlbumImagesMap());
 
   TestNonexistentDirectory(std::string(kPicasaDirFolders) + "/foo");
   TestNonexistentDirectory(std::string(kPicasaDirFolders) + "/foo/bar");
   TestNonexistentDirectory(std::string(kPicasaDirFolders) + "/foo/bar/baz");
 }
 
 TEST_F(PicasaFileUtilTest, FolderContentsTrivial) {
   ScopedVector<TestFolder> test_folders;
-  base::Time test_date = base::Time::FromLocalExploded(test_date_exploded);
+  base::Time test_date;
+  EXPECT_TRUE(base::Time::FromLocalExploded(test_date_exploded, &test_date));
 
   test_folders.push_back(
       new TestFolder("folder-1-empty", test_date, "uid-empty", 0, 0));
   test_folders.push_back(
       new TestFolder("folder-2-images", test_date, "uid-images", 5, 0));
   test_folders.push_back(
       new TestFolder("folder-3-nonimages", test_date, "uid-nonimages", 0, 5));
   test_folders.push_back(
       new TestFolder("folder-4-both", test_date, "uid-both", 5, 5));
 
   SetupFolders(&test_folders, std::vector<AlbumInfo>(), AlbumImagesMap());
   VerifyFolderDirectoryList(test_folders);
 }
 
 TEST_F(PicasaFileUtilTest, FolderWithManyFiles) {
   ScopedVector<TestFolder> test_folders;
-  base::Time test_date = base::Time::FromLocalExploded(test_date_exploded);
+  base::Time test_date;
+  EXPECT_TRUE(base::Time::FromLocalExploded(test_date_exploded, &test_date));
 
   test_folders.push_back(
       new TestFolder("folder-many-files", test_date, "uid-both", 50, 50));
 
   SetupFolders(&test_folders, std::vector<AlbumInfo>(), AlbumImagesMap());
   VerifyFolderDirectoryList(test_folders);
 }
 
 TEST_F(PicasaFileUtilTest, ManyFolders) {
   ScopedVector<TestFolder> test_folders;
-  base::Time test_date = base::Time::FromLocalExploded(test_date_exploded);
+  base::Time test_date;
+  EXPECT_TRUE(base::Time::FromLocalExploded(test_date_exploded, &test_date));
 
   for (unsigned int i = 0; i < 50; ++i) {
     base::Time date = test_date - base::TimeDelta::FromDays(i);
 
     test_folders.push_back(
         new TestFolder(base::StringPrintf("folder-%05d", i),
                        date,
                        base::StringPrintf("uid%05d", i), i % 5, i % 3));
   }
 
   SetupFolders(&test_folders, std::vector<AlbumInfo>(), AlbumImagesMap());
   VerifyFolderDirectoryList(test_folders);
 }
 
 TEST_F(PicasaFileUtilTest, AlbumExistence) {
   ScopedVector<TestFolder> test_folders;
-  base::Time test_date = base::Time::FromLocalExploded(test_date_exploded);
+  base::Time test_date;
+  EXPECT_TRUE(base::Time::FromLocalExploded(test_date_exploded, &test_date));
 
   std::vector<AlbumInfo> albums;
   AlbumInfo info;
   info.name = "albumname";
   info.uid = "albumuid";
   info.timestamp = test_date;
   albums.push_back(info);
 
   AlbumImagesMap albums_images;
   albums_images[info.uid] = AlbumImages();
 
   SetupFolders(&test_folders, albums, albums_images);
 
   TestEmptyDirectory(std::string(kPicasaDirAlbums) + "/albumname 2013-04-16");
   TestNonexistentDirectory(std::string(kPicasaDirAlbums) +
                            "/albumname 2013-04-16/toodeep");
   TestNonexistentDirectory(std::string(kPicasaDirAlbums) + "/wrongname");
 }
 
 TEST_F(PicasaFileUtilTest, AlbumContents) {
   ScopedVector<TestFolder> test_folders;
-  base::Time test_date = base::Time::FromLocalExploded(test_date_exploded);
+  base::Time test_date;
+  EXPECT_TRUE(base::Time::FromLocalExploded(test_date_exploded, &test_date));
 
   std::vector<AlbumInfo> albums;
   AlbumInfo info;
   info.name = "albumname";
   info.uid = "albumuid";
   info.timestamp = test_date;
   albums.push_back(info);
 
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
@@ skipping 31 matching lines @@
   operation_runner()->CreateSnapshotFile(
       CreateURL(std::string(kPicasaDirAlbums) +
                 "/albumname 2013-04-16/mapped_name.jpg"),
       snapshot_callback);
   loop.Run();
   EXPECT_EQ(base::File::FILE_OK, error);
   EXPECT_EQ(image_path, platform_path_result);
 }
 
 }  // namespace picasa