Make callers of FromUTC(Local)Exploded in chrome/ use new time API.

chrome/utility/media_galleries/picasa_album_table_reader.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/utility/media_galleries/picasa_album_table_reader.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <string>
 #include <utility>
 
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/media_galleries/pmp_constants.h"
 #include "chrome/utility/media_galleries/pmp_column_reader.h"
 
 namespace picasa {
 
 namespace {
 
 // |variant_time| is specified as the number of days from Dec 30, 1899.
 base::Time TimeFromMicrosoftVariantTime(double variant_time) {
   base::TimeDelta variant_delta = base::TimeDelta::FromMicroseconds(
       static_cast<int64_t>(variant_time * base::Time::kMicrosecondsPerDay));
 
-  return base::Time::FromLocalExploded(kPmpVariantTimeEpoch) + variant_delta;
+  base::Time out_time;
+  if (!base::Time::FromLocalExploded(kPmpVariantTimeEpoch, &out_time)) {

[Lei Zhang, 2016/07/06 17:44:30]

Isn't |kPmpVariantTimeEpoch| also a known to be good date that should no fail?

[maksims (do not use this acc), 2016/07/07 05:48:14]

Done.

+    // TODO(maksims): implement error handling.
+    // We might just return |out_time|, which is Time(0).
+    NOTIMPLEMENTED();
+    return out_time;
+  }
+
+  return out_time + variant_delta;
 }
 
 }  // namespace
 
 PicasaAlbumTableReader::PicasaAlbumTableReader(AlbumTableFiles table_files)
     : table_files_(std::move(table_files)), initialized_(false) {}
 
 PicasaAlbumTableReader::~PicasaAlbumTableReader() {
 }
 
@@ skipping 70 matching lines @@
 
       folders_.push_back(AlbumInfo(name, timestamp, uid, path));
     }
   }
 
   initialized_ = true;
   return true;
 }
 
 }  // namespace picasa