Make callers of FromUTC(Local)Exploded in chrome/ use new time API.

chrome/browser/ui/webui/media/webrtc_logs_ui.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/media/webrtc_logs_ui.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 164 matching lines @@
     if (!i->capture_time.is_null()) {
       value_w = base::TimeFormatFriendlyDateAndTime(i->capture_time);
     } else {
       // Fall back on local ID as time. We need to check that it's within
       // resonable bounds, since the ID may not represent time. Check between
       // 2012 when the feature was introduced and now.
       double seconds_since_epoch;
       if (base::StringToDouble(i->local_id, &seconds_since_epoch)) {
         base::Time capture_time = base::Time::FromDoubleT(seconds_since_epoch);
         base::Time::Exploded lower_limit = {2012, 1, 0, 1, 0, 0, 0, 0};
-        if (capture_time > base::Time::FromUTCExploded(lower_limit) &&
-            capture_time < base::Time::Now()) {
-          value_w = base::TimeFormatFriendlyDateAndTime(capture_time);
+        base::Time out_time;
+        if (base::Time::FromUTCExploded(lower_limit, &out_time)) {

[Lei Zhang, 2016/07/06 17:44:30]

Isn't |lower_limit| a known to be good value that should never fail? Can we
DCHECK() that the conversion is successful?

|lower_limit| should also be const.

[maksims (do not use this acc), 2016/07/07 05:48:14]

Done.

+          if (capture_time > out_time && capture_time < base::Time::Now()) {
+            value_w = base::TimeFormatFriendlyDateAndTime(capture_time);
+          }
         }
       }
     }
     // If we haven't set |value_w| above, we fall back on the upload time, which
     // was already in the variable. In case it's empty set the string to
     // inform that the time is unknown.
     if (value_w.empty())
       value_w = base::string16(base::ASCIIToUTF16("(unknown time)"));
     upload->SetString("capture_time", value_w);
 
@@ skipping 14 matching lines @@
 //
 ///////////////////////////////////////////////////////////////////////////////
 
 WebRtcLogsUI::WebRtcLogsUI(content::WebUI* web_ui) : WebUIController(web_ui) {
   Profile* profile = Profile::FromWebUI(web_ui);
   web_ui->AddMessageHandler(new WebRtcLogsDOMHandler(profile));
 
   // Set up the chrome://webrtc-logs/ source.
   content::WebUIDataSource::Add(profile, CreateWebRtcLogsUIHTMLSource());
 }