Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 2111023002: [MD settings] closure compile settings menu (Closed)

Created:
4 years, 5 months ago by dschuyler
Modified:
4 years, 5 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] closure compile settings menu This CL adds closure compilation to the settings menu directory. BUG=425627 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f486c19ecfeb8c3a1932aa18cbf2ff56339f05e7 Cr-Commit-Position: refs/heads/master@{#403281}

Patch Set 1 #

Patch Set 2 : merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/resources/settings/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/resources/settings/settings_menu/compiled_resources2.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
dschuyler
4 years, 5 months ago (2016-06-30 02:13:38 UTC) #3
tommycli
lgtm
4 years, 5 months ago (2016-06-30 16:13:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111023002/1
4 years, 5 months ago (2016-06-30 17:15:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/210570)
4 years, 5 months ago (2016-06-30 17:24:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111023002/20001
4 years, 5 months ago (2016-06-30 20:52:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 20:59:51 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 20:59:55 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 21:01:10 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f486c19ecfeb8c3a1932aa18cbf2ff56339f05e7
Cr-Commit-Position: refs/heads/master@{#403281}

Powered by Google App Engine
This is Rietveld 408576698