Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1745)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 21110003: Implement MirrorUsed.targets for libraries (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r25609 and added test. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
index 07284861c76eb438b7ce1d14b9570ee6bddfade5..607bc6e9d35a50fe61c2b1c3b3d1ca290bd42a11 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
@@ -2217,7 +2217,9 @@ class ResolverVisitor extends MappingVisitor<Element> {
Element target = resolveSend(node);
sendIsMemberAccess = oldSendIsMemberAccess;
- if (target != null && target == compiler.mirrorSystemGetNameFunction) {
+ if (target != null
+ && target == compiler.mirrorSystemGetNameFunction
+ && !compiler.mirrorUsageAnalyzerTask.hasMirrorUsage(enclosingElement)) {
compiler.reportHint(
node.selector, MessageKind.STATIC_FUNCTION_BLOAT,
{'class': compiler.mirrorSystemClass.name,
@@ -2635,9 +2637,12 @@ class ResolverVisitor extends MappingVisitor<Element> {
}
}
} else {
- compiler.reportHint(
- node.newToken, MessageKind.NON_CONST_BLOAT,
- {'name': compiler.symbolClass.name});
+ if (!compiler.mirrorUsageAnalyzerTask.hasMirrorUsage(
+ enclosingElement)) {
+ compiler.reportHint(
+ node.newToken, MessageKind.NON_CONST_BLOAT,
+ {'name': compiler.symbolClass.name});
+ }
world.registerNewSymbol(mapping);
}
}

Powered by Google App Engine
This is Rietveld 408576698