Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2110993003: Filter out empty usernames while handling get() in the Credential Manager API. (Closed)

Created:
4 years, 5 months ago by vasilii
Modified:
4 years, 5 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Filter out empty usernames while handling get() in the Credential Manager API. Empty usernames aren't supported by the partners. Therefore, every time we return it or show it in the account chooser we worsen the UX. BUG=400674 Committed: https://crrev.com/97606463c16d7f18542ad336ced24e962d1b73a2 Cr-Commit-Position: refs/heads/master@{#403208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
M components/password_manager/content/browser/credential_manager_impl_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/credential_manager_pending_request_task.cc View 3 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vasilii
Hi Vaclav, please review.
4 years, 5 months ago (2016-06-30 15:43:35 UTC) #2
vabr (Chromium)
Both the goal and its implementation LGTM. Thanks, Vaclav
4 years, 5 months ago (2016-06-30 16:54:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110993003/1
4 years, 5 months ago (2016-06-30 17:14:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 17:30:55 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 17:32:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97606463c16d7f18542ad336ced24e962d1b73a2
Cr-Commit-Position: refs/heads/master@{#403208}

Powered by Google App Engine
This is Rietveld 408576698