[Mac] Refactor Cocoa fullscreen code

[Mac] Refactor Cocoa fullscreen code

- Renamed PresentationModeController to FullscreenToolbarController
- Removed Lion fullscreen methods
- Updated comments and variable names

BUG=579259
Committed: https://crrev.com/e7f9456d7512988bc01ac54b698de5d80ef8fb77
Cr-Commit-Position: refs/heads/master@{#403316}

[spqchan, 2016-06-29 22:55:18]

Description was changed from

==========
[Mac] Refactor fullscreen code

BUG=
==========

to

==========
[Mac] Refactor fullscreen code

- Renamed PresentationModeController to FullscreenToolbarController
- Removed Lion fullscreen methods
- Updated comments

BUG=
==========

[spqchan, 2016-06-29 23:51:15]

Description was changed from

==========
[Mac] Refactor fullscreen code

- Renamed PresentationModeController to FullscreenToolbarController
- Removed Lion fullscreen methods
- Updated comments

BUG=
==========

to

==========
[Mac] Refactor fullscreen code

- Renamed PresentationModeController to FullscreenToolbarController
- Removed Lion fullscreen methods
- Updated comments

BUG=579259
==========

[spqchan, 2016-06-29 23:51:27]

Description was changed from

==========
[Mac] Refactor fullscreen code

- Renamed PresentationModeController to FullscreenToolbarController
- Removed Lion fullscreen methods
- Updated comments

BUG=579259
==========

to

==========
[Mac] Refactor fullscreen code

- Renamed PresentationModeController to FullscreenToolbarController
- Removed Lion fullscreen methods
- Updated comments and variable names

BUG=579259
==========

[spqchan, 2016-06-29 23:51:48]

Description was changed from

==========
[Mac] Refactor fullscreen code

- Renamed PresentationModeController to FullscreenToolbarController
- Removed Lion fullscreen methods
- Updated comments and variable names

BUG=579259
==========

to

==========
[Mac] Refactor Cocoa fullscreen code

- Renamed PresentationModeController to FullscreenToolbarController
- Removed Lion fullscreen methods
- Updated comments and variable names

BUG=579259
==========

[spqchan, 2016-06-29 23:51:48]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2016-06-29 23:54:13]

PTAL

Hopefully this will be the final stretch for the purge :D

[Robert Sesek, 2016-06-30 17:40:09]

There's also test failures on the trybot runs.

https://codereview.chromium.org/2110983002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right):

https://codereview.chromium.org/2110983002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:44: #import
"chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h"
Is this unused in this file?

https://codereview.chromium.org/2110983002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (left):

https://codereview.chromium.org/2110983002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:929:
base::mac::ObjCCast<FramedBrowserWindow>([self window])) {
Why are we shedding the casts?

https://codereview.chromium.org/2110983002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/download/download_shelf_controller.mm (right):

https://codereview.chromium.org/2110983002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/download/download_shelf_controller.mm:23: #import
"chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h"
Is this used in this file?

[spqchan, 2016-06-30 19:46:30]

PTAL

Fixed the test

https://codereview.chromium.org/2110983002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right):

https://codereview.chromium.org/2110983002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:44: #import
"chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h"
On 2016/06/30 17:40:09, Robert Sesek wrote:
> Is this unused in this file?

Good point. It was using kWillEnterFullscreenNotification and
kWillLeaveFullscreenNotification from PresentationModeController. I removed the
notifications and replaced them with NSWindowWillEnterFullscreen and
NSWindowWillExitFullscreen

https://codereview.chromium.org/2110983002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (left):

https://codereview.chromium.org/2110983002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:929:
base::mac::ObjCCast<FramedBrowserWindow>([self window])) {
On 2016/06/30 17:40:09, Robert Sesek wrote:
> Why are we shedding the casts?

toggleSystemFullscreen: was implemented in FramedBrowserWindow
Basically it checks if we're in Lion or not.

If we're Lion, it will call handleLionToggleFullscreen
Otherwise it will call toggleFullscreen.

Since we no longer need handleLionToggleFullscreen, I got rid of
toggleSystemFullscreen: in FramedBrowserWindow. We just need toggleFullscreen so
we don't need the cast anymore.

https://codereview.chromium.org/2110983002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/download/download_shelf_controller.mm (right):

https://codereview.chromium.org/2110983002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/download/download_shelf_controller.mm:23: #import
"chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h"
On 2016/06/30 17:40:09, Robert Sesek wrote:
> Is this used in this file?

ditto as bookmarks_bar_controller

[Robert Sesek, 2016-06-30 21:27:04]

lgtm

[spqchan, 2016-06-30 21:30:17]

Thanks!

[spqchan, 2016-06-30 21:30:21]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2016-06-30 21:31:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 21:40:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 21:40:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[spqchan, 2016-06-30 21:57:51]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-06-30 21:57:52]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2110983002/#ps80001
(title: "Replaced NSTrackingArea with CrTrackingArea")

[commit-bot: I haz the power, 2016-06-30 21:58:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 22:48:09]

Description was changed from

==========
[Mac] Refactor Cocoa fullscreen code

- Renamed PresentationModeController to FullscreenToolbarController
- Removed Lion fullscreen methods
- Updated comments and variable names

BUG=579259
==========

to

==========
[Mac] Refactor Cocoa fullscreen code

- Renamed PresentationModeController to FullscreenToolbarController
- Removed Lion fullscreen methods
- Updated comments and variable names

BUG=579259
==========

[commit-bot: I haz the power, 2016-06-30 22:48:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-30 22:50:21]

Description was changed from

==========
[Mac] Refactor Cocoa fullscreen code

- Renamed PresentationModeController to FullscreenToolbarController
- Removed Lion fullscreen methods
- Updated comments and variable names

BUG=579259
==========

to

==========
[Mac] Refactor Cocoa fullscreen code

- Renamed PresentationModeController to FullscreenToolbarController
- Removed Lion fullscreen methods
- Updated comments and variable names

BUG=579259

Committed: https://crrev.com/e7f9456d7512988bc01ac54b698de5d80ef8fb77
Cr-Commit-Position: refs/heads/master@{#403316}
==========

[commit-bot: I haz the power, 2016-06-30 22:50:23]

Patchset 5 (id:??) landed as
https://crrev.com/e7f9456d7512988bc01ac54b698de5d80ef8fb77
Cr-Commit-Position: refs/heads/master@{#403316}