Removing load_flags from ProxyService and ProxyDelegate

Removing load_flags from ProxyService and ProxyDelegate

load_flags used to be used in DataReductionProxyDelegate to resolve the
proxy, but it no longer does. load_flags should not be needed to resolve
a proxy for a request.

load_flags was previously used for the CriticalPathBypassFieldTrial:

https://chromium.googlesource.com/chromium/src/+/db1198c5327b5c69b93fafd814b9f516b88a15fd%5E%21/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

BUG=

Committed: https://crrev.com/7bd591a9c4dc9c3a183bbab9d705ca53c9287085
Cr-Commit-Position: refs/heads/master@{#406112}

[RyanSturm, 2016-06-29 23:03:43]

ryansturm@chromium.org changed reviewers:
+ bengr@chromium.org

[RyanSturm, 2016-06-29 23:03:44]

bengr: PTAL before I send it to net/ review

[bengr, 2016-07-08 16:30:11]

On 2016/06/29 23:03:44, RyanSturm wrote:
> bengr: PTAL before I send it to net/ review

Why had the drp_delegate used load_flags and why does it not anymore? It would
be helpful to have that context.

[RyanSturm, 2016-07-08 17:41:59]

Description was changed from

==========
Removing load_flags from ProxyService and ProxyDelegate

load_flags used to be used in DataReductionProxyDelegate to resolve the
proxy, but it no longer does. load_flags should not be needed to resolve
a proxy for a request.

BUG=
==========

to

==========
Removing load_flags from ProxyService and ProxyDelegate

load_flags used to be used in DataReductionProxyDelegate to resolve the
proxy, but it no longer does. load_flags should not be needed to resolve
a proxy for a request.

load_flags was previously used for the CriticalPathBypassFieldTrial:

https://chromium.googlesource.com/chromium/src/+/db1198c5327b5c69b93fafd814b9...

BUG=
==========

[RyanSturm, 2016-07-08 17:42:25]

On 2016/07/08 16:30:11, bengr wrote:
> On 2016/06/29 23:03:44, RyanSturm wrote:
> > bengr: PTAL before I send it to net/ review
> 
> Why had the drp_delegate used load_flags and why does it not anymore? It would
> be helpful to have that context.

Added details in description.

[bengr, 2016-07-18 16:13:24]

lgtm

[bengr, 2016-07-18 16:13:24]

lgtm

lgtm

[RyanSturm, 2016-07-18 17:06:26]

mmenke: PTAL, thanks

[RyanSturm, 2016-07-18 17:06:52]

ryansturm@chromium.org changed reviewers:
+ mmenke@chromium.org

[RyanSturm, 2016-07-18 17:06:52]

mmenke: PTAL, thanks

[mmenke, 2016-07-18 17:10:09]

On 2016/07/18 17:06:52, RyanSturm wrote:
> mmenke: PTAL, thanks

Awesome!  Anything we can do to narrow the scope of LoadFlags is great.  LGTM!

[RyanSturm, 2016-07-18 17:56:43]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 17:57:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2016-07-18 18:05:04]

ryansturm@chromium.org changed reviewers:
+ nasko@chromium.org, stevenjb@chromium.org, zea@chromium.org

[RyanSturm, 2016-07-18 18:05:04]

nasko: PTAL @ content/*

zea: PTAL @ google_apis/gcm/engine/connection_factory_impl.cc and
jingle/glue/proxy_resolving_client_socket.cc

stevenjb: PTAL @ chromeos/dbus/services/proxy_resolution_service_provider.cc

thanks

[stevenjb, 2016-07-18 18:16:23]

chromeos/dbus lgtm

[commit-bot: I haz the power, 2016-07-18 19:34:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 19:34:32]

Dry run: This issue passed the CQ dry run.

[Nicolas Zea, 2016-07-18 19:46:52]

gcm and jingle lgtm

[nasko, 2016-07-18 21:36:16]

content/ LGTM

[RyanSturm, 2016-07-18 21:40:59]

The CQ bit was checked by ryansturm@chromium.org

[RyanSturm, 2016-07-18 21:41:00]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org,
mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2110973002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-18 21:42:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 21:58:12]

Description was changed from

==========
Removing load_flags from ProxyService and ProxyDelegate

load_flags used to be used in DataReductionProxyDelegate to resolve the
proxy, but it no longer does. load_flags should not be needed to resolve
a proxy for a request.

load_flags was previously used for the CriticalPathBypassFieldTrial:

https://chromium.googlesource.com/chromium/src/+/db1198c5327b5c69b93fafd814b9...

BUG=
==========

to

==========
Removing load_flags from ProxyService and ProxyDelegate

load_flags used to be used in DataReductionProxyDelegate to resolve the
proxy, but it no longer does. load_flags should not be needed to resolve
a proxy for a request.

load_flags was previously used for the CriticalPathBypassFieldTrial:

https://chromium.googlesource.com/chromium/src/+/db1198c5327b5c69b93fafd814b9...

BUG=
==========

[commit-bot: I haz the power, 2016-07-18 21:58:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-18 21:58:30]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 22:03:03]

Description was changed from

==========
Removing load_flags from ProxyService and ProxyDelegate

load_flags used to be used in DataReductionProxyDelegate to resolve the
proxy, but it no longer does. load_flags should not be needed to resolve
a proxy for a request.

load_flags was previously used for the CriticalPathBypassFieldTrial:

https://chromium.googlesource.com/chromium/src/+/db1198c5327b5c69b93fafd814b9...

BUG=
==========

to

==========
Removing load_flags from ProxyService and ProxyDelegate

load_flags used to be used in DataReductionProxyDelegate to resolve the
proxy, but it no longer does. load_flags should not be needed to resolve
a proxy for a request.

load_flags was previously used for the CriticalPathBypassFieldTrial:

https://chromium.googlesource.com/chromium/src/+/db1198c5327b5c69b93fafd814b9...

BUG=

Committed: https://crrev.com/7bd591a9c4dc9c3a183bbab9d705ca53c9287085
Cr-Commit-Position: refs/heads/master@{#406112}
==========

[commit-bot: I haz the power, 2016-07-18 22:03:05]

Patchset 2 (id:??) landed as
https://crrev.com/7bd591a9c4dc9c3a183bbab9d705ca53c9287085
Cr-Commit-Position: refs/heads/master@{#406112}