Issue 211093005: [WebSocket] Add close-before-open layout test for workers

Issue 211093005: [WebSocket] Add close-before-open layout test for workers (Closed)

Created:
6 years, 9 months ago by tyoshino (SeeGerritForStatus)

Modified:
6 years, 8 months ago

Reviewers:
yhirano

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[WebSocket] Add close-before-open layout test for workers BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170529

Patch Set 2 : Addressed #2 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -0 lines)			Patch
A	LayoutTests/http/tests/websocket/workers/close-before-open.html	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/websocket/workers/close-before-open-expected.txt	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/websocket/workers/resources/close-before-open.js	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yhirano

lgtm lgtm https://codereview.chromium.org/211093005/diff/1/LayoutTests/http/tests/websocket/workers/resources/close-before-open.js File LayoutTests/http/tests/websocket/workers/resources/close-before-open.js (right): https://codereview.chromium.org/211093005/diff/1/LayoutTests/http/tests/websocket/workers/resources/close-before-open.js#newcode2 LayoutTests/http/tests/websocket/workers/resources/close-before-open.js:2: ws.close(); I think it's a good idea ...

6 years, 9 months ago (2014-03-26 07:22:32 UTC) #2

tyoshino (SeeGerritForStatus)

https://codereview.chromium.org/211093005/diff/1/LayoutTests/http/tests/websocket/workers/resources/close-before-open.js File LayoutTests/http/tests/websocket/workers/resources/close-before-open.js (right): https://codereview.chromium.org/211093005/diff/1/LayoutTests/http/tests/websocket/workers/resources/close-before-open.js#newcode2 LayoutTests/http/tests/websocket/workers/resources/close-before-open.js:2: ws.close(); On 2014/03/26 07:22:32, yhirano wrote: > I think ...

6 years, 8 months ago (2014-04-01 06:56:01 UTC) #3

tyoshino (SeeGerritForStatus)

The CQ bit was checked by tyoshino@chromium.org

6 years, 8 months ago (2014-04-01 06:56:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/211093005/60001

6 years, 8 months ago (2014-04-01 06:56:13 UTC) #5

Message was sent while issue was closed.

Change committed as 170529

Expand Messages | Collapse Messages