Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: LayoutTests/fast/forms/select/listbox-tap.html

Issue 211093004: Tapping <select multiple> option toggles selection (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/forms/select/listbox-tap.html
diff --git a/LayoutTests/fast/forms/select/listbox-tap.html b/LayoutTests/fast/forms/select/listbox-tap.html
new file mode 100644
index 0000000000000000000000000000000000000000..04605be81ef2685eeeb406d2efb21925cda62c8f
--- /dev/null
+++ b/LayoutTests/fast/forms/select/listbox-tap.html
@@ -0,0 +1,59 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../../resources/js-test.js"></script>
+<select id="select1" multiple size="4">
+<option>1</option>
+<option>2</option>
+<option>3</option>
+</select>
+
+<script>
+description('Tapping on listbox items should toggle selection.');
tkent 2014/03/26 03:21:32 Please use consistent quotation marks. This line
keishi 2014/03/26 09:16:27 Done.
+
+function tapOption(select, index) {
+ var itemHeight = Math.floor(select.offsetHeight / select.size);
+ var border = 1;
+ var y = border + index * itemHeight;
+
+ select.focus();
+ if (window.eventSender) {
+ eventSender.gestureTap(select.offsetLeft + border, select.offsetTop + y - window.pageYOffset, 10, 10);
+ }
+}
+
+function getSelectedValues(select) {
+ var selectedValues = [];
+ for (var i = 0; i < select.options.length; i++) {
+ var option = select.options[i];
+ if (option.selected)
+ selectedValues.push(option.value);
+ }
+ return selectedValues.join(",");
+}
+
+var select = document.getElementById("select1");
+
+if (!window.eventSender) {
+ debug('Click on the scrollbar. The test passes if nothing is printed.');
tkent 2014/03/26 03:21:32 This message looks wrong. Please use consistent q
keishi 2014/03/26 09:16:27 Done.
+} else {
+ shouldBeEqualToString("getSelectedValues(select)", "");
+
+ tapOption(select, 0);
+ shouldBeEqualToString("getSelectedValues(select)", "1");
+ tapOption(select, 1);
+ shouldBeEqualToString("getSelectedValues(select)", "1,2");
+ tapOption(select, 2);
+ shouldBeEqualToString("getSelectedValues(select)", "1,2,3");
+ tapOption(select, 3);
+ shouldBeEqualToString("getSelectedValues(select)", "1,2,3");
+ tapOption(select, 1);
+ shouldBeEqualToString("getSelectedValues(select)", "1,3");
+ tapOption(select, 0);
+ shouldBeEqualToString("getSelectedValues(select)", "3");
+ tapOption(select, 2);
+ shouldBeEqualToString("getSelectedValues(select)", "");
+}
+</script>
+
+</html>
« no previous file with comments | « no previous file | LayoutTests/fast/forms/select/listbox-tap-expected.txt » ('j') | Source/core/html/HTMLSelectElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698