Tapping <select multiple> option toggles selection

Tapping <select multiple> option toggles selection

We want to be able to use <select multiple> with only touch.
Mouse behavior won't change.

BUG=356499
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170111

[tkent, 2014-03-26 03:21:32]

https://codereview.chromium.org/211093004/diff/30001/LayoutTests/fast/forms/s...
File LayoutTests/fast/forms/select/listbox-tap.html (right):

https://codereview.chromium.org/211093004/diff/30001/LayoutTests/fast/forms/s...
LayoutTests/fast/forms/select/listbox-tap.html:12: description('Tapping on
listbox items should toggle selection.');
Please use consistent quotation marks.  This line uses ' and almost all of
others use ".

https://codereview.chromium.org/211093004/diff/30001/LayoutTests/fast/forms/s...
LayoutTests/fast/forms/select/listbox-tap.html:38: debug('Click on the
scrollbar. The test passes if nothing is printed.');
This message looks wrong.

Please use consistent quotation marks.  This line uses ' and almost all of
others use ".

https://codereview.chromium.org/211093004/diff/30001/Source/core/html/HTMLSel...
File Source/core/html/HTMLSelectElement.cpp (right):

https://codereview.chromium.org/211093004/diff/30001/Source/core/html/HTMLSel...
Source/core/html/HTMLSelectElement.cpp:1331: GestureEvent* gestureEvent =
toGestureEvent(event);
Because we can assume event is not null, we can use a reference.
    GestureEvent& gestureEvent = toGestureEvent(*event);

https://codereview.chromium.org/211093004/diff/30001/Source/core/html/HTMLSel...
Source/core/html/HTMLSelectElement.cpp:1339: event->setDefaultHandled();
You call setDefaultHandled twice.

[keishi, 2014-03-26 09:16:27]

https://codereview.chromium.org/211093004/diff/30001/LayoutTests/fast/forms/s...
File LayoutTests/fast/forms/select/listbox-tap.html (right):

https://codereview.chromium.org/211093004/diff/30001/LayoutTests/fast/forms/s...
LayoutTests/fast/forms/select/listbox-tap.html:12: description('Tapping on
listbox items should toggle selection.');
On 2014/03/26 03:21:32, tkent wrote:
> Please use consistent quotation marks.  This line uses ' and almost all of
> others use ".

Done.

https://codereview.chromium.org/211093004/diff/30001/LayoutTests/fast/forms/s...
LayoutTests/fast/forms/select/listbox-tap.html:38: debug('Click on the
scrollbar. The test passes if nothing is printed.');
On 2014/03/26 03:21:32, tkent wrote:
> This message looks wrong.
> 
> Please use consistent quotation marks.  This line uses ' and almost all of
> others use ".

Done.

https://codereview.chromium.org/211093004/diff/30001/Source/core/html/HTMLSel...
File Source/core/html/HTMLSelectElement.cpp (right):

https://codereview.chromium.org/211093004/diff/30001/Source/core/html/HTMLSel...
Source/core/html/HTMLSelectElement.cpp:1331: GestureEvent* gestureEvent =
toGestureEvent(event);
On 2014/03/26 03:21:32, tkent wrote:
> Because we can assume event is not null, we can use a reference.
>     GestureEvent& gestureEvent = toGestureEvent(*event);

Done.

https://codereview.chromium.org/211093004/diff/30001/Source/core/html/HTMLSel...
Source/core/html/HTMLSelectElement.cpp:1339: event->setDefaultHandled();
On 2014/03/26 03:21:32, tkent wrote:
> You call setDefaultHandled twice.

Done.

[tkent, 2014-03-26 09:18:22]

lgtm

[commit-bot: I haz the power, 2014-03-26 09:18:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keishi@chromium.org/211093004/130001

[commit-bot: I haz the power, 2014-03-26 09:42:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 09:42:28]

Try jobs failed on following builders:
  tryserver.blink on win_blink_compile_dbg

[tkent, 2014-03-26 23:33:52]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-03-26 23:33:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keishi@chromium.org/211093004/130001

[commit-bot: I haz the power, 2014-03-27 00:06:09]

Change committed as 170111