Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2110903003: Revert of third_party: Update to version 8 of remote_shell_protocol (Closed)

Created:
4 years, 5 months ago by horo
Modified:
4 years, 5 months ago
Reviewers:
reveman, oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of third_party: Update to version 8 of remote_shell_protocol (patchset #5 id:180001 of https://codereview.chromium.org/2104473002/ ) Reason for revert: ShellSurfaceTest.ModalWindow failure in Linux ChromiumOS GN (dbg). https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN%20%28dbg%29/builds/23005 (view as text) ShellSurfaceTest.ModalWindow (run #1): [ RUN ] ShellSurfaceTest.ModalWindow Xlib: extension "RANDR" missing on display ":9". ../../components/exo/shell_surface_unittest.cc:420: Failure Value of: ash::WmShell::Get()->IsSystemModalWindowOpen() Actual: false Expected: true [ FAILED ] ShellSurfaceTest.ModalWindow (210 ms) ShellSurfaceTest.ModalWindow (run #2): [ RUN ] ShellSurfaceTest.ModalWindow Xlib: extension "RANDR" missing on display ":9". ../../components/exo/shell_surface_unittest.cc:420: Failure Value of: ash::WmShell::Get()->IsSystemModalWindowOpen() Actual: false Expected: true [ FAILED ] ShellSurfaceTest.ModalWindow (326 ms) ShellSurfaceTest.ModalWindow (run #3): [ RUN ] ShellSurfaceTest.ModalWindow Xlib: extension "RANDR" missing on display ":9". ../../components/exo/shell_surface_unittest.cc:420: Failure Value of: ash::WmShell::Get()->IsSystemModalWindowOpen() Actual: false Expected: true [ FAILED ] ShellSurfaceTest.ModalWindow (352 ms) ShellSurfaceTest.ModalWindow (run #4): [ RUN ] ShellSurfaceTest.ModalWindow Xlib: extension "RANDR" missing on display ":9". ../../components/exo/shell_surface_unittest.cc:420: Failure Value of: ash::WmShell::Get()->IsSystemModalWindowOpen() Actual: false Expected: true [ FAILED ] ShellSurfaceTest.ModalWindow (349 ms) Original issue's description: > third_party: Update to version 8 of remote_shell_protocol > > * Add remote-shell interface to control system modality > * Add shell-mode event to notify the shell mode switch > * Shadow underlay should be deleted when shadow is turned off > > BUG=b/29625835, b/29229887 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/b477262b8b9db47e5589304d26fb9338f64c2194 > Cr-Commit-Position: refs/heads/master@{#403028} TBR=reveman@chromium.org,oshima@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=b/29625835, b/29229887 Committed: https://crrev.com/141947e2022ad00f7e947cdeea8204a1617b074f Cr-Commit-Position: refs/heads/master@{#403061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -215 lines) Patch
M components/exo/shell_surface.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/exo/shell_surface.cc View 6 chunks +12 lines, -25 lines 0 comments Download
M components/exo/wayland/server.cc View 5 chunks +2 lines, -26 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h View 5 chunks +0 lines, -66 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h View 5 chunks +0 lines, -52 lines 0 comments Download
M third_party/wayland-protocols/protocol/remote-shell-protocol.c View 3 chunks +4 lines, -7 lines 0 comments Download
M third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml View 4 chunks +2 lines, -36 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
horo
Created Revert of third_party: Update to version 8 of remote_shell_protocol
4 years, 5 months ago (2016-06-30 01:47:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110903003/1
4 years, 5 months ago (2016-06-30 01:48:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 01:48:45 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 01:48:52 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 01:50:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/141947e2022ad00f7e947cdeea8204a1617b074f
Cr-Commit-Position: refs/heads/master@{#403061}

Powered by Google App Engine
This is Rietveld 408576698