DescriptionRevert of third_party: Update to version 8 of remote_shell_protocol (patchset #5 id:180001 of https://codereview.chromium.org/2104473002/ )
Reason for revert:
ShellSurfaceTest.ModalWindow failure in Linux ChromiumOS GN (dbg).
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN%20%28dbg%29/builds/23005
(view as text)
ShellSurfaceTest.ModalWindow (run #1):
[ RUN ] ShellSurfaceTest.ModalWindow
Xlib: extension "RANDR" missing on display ":9".
../../components/exo/shell_surface_unittest.cc:420: Failure
Value of: ash::WmShell::Get()->IsSystemModalWindowOpen()
Actual: false
Expected: true
[ FAILED ] ShellSurfaceTest.ModalWindow (210 ms)
ShellSurfaceTest.ModalWindow (run #2):
[ RUN ] ShellSurfaceTest.ModalWindow
Xlib: extension "RANDR" missing on display ":9".
../../components/exo/shell_surface_unittest.cc:420: Failure
Value of: ash::WmShell::Get()->IsSystemModalWindowOpen()
Actual: false
Expected: true
[ FAILED ] ShellSurfaceTest.ModalWindow (326 ms)
ShellSurfaceTest.ModalWindow (run #3):
[ RUN ] ShellSurfaceTest.ModalWindow
Xlib: extension "RANDR" missing on display ":9".
../../components/exo/shell_surface_unittest.cc:420: Failure
Value of: ash::WmShell::Get()->IsSystemModalWindowOpen()
Actual: false
Expected: true
[ FAILED ] ShellSurfaceTest.ModalWindow (352 ms)
ShellSurfaceTest.ModalWindow (run #4):
[ RUN ] ShellSurfaceTest.ModalWindow
Xlib: extension "RANDR" missing on display ":9".
../../components/exo/shell_surface_unittest.cc:420: Failure
Value of: ash::WmShell::Get()->IsSystemModalWindowOpen()
Actual: false
Expected: true
[ FAILED ] ShellSurfaceTest.ModalWindow (349 ms)
Original issue's description:
> third_party: Update to version 8 of remote_shell_protocol
>
> * Add remote-shell interface to control system modality
> * Add shell-mode event to notify the shell mode switch
> * Shadow underlay should be deleted when shadow is turned off
>
> BUG=b/29625835, b/29229887
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/b477262b8b9db47e5589304d26fb9338f64c2194
> Cr-Commit-Position: refs/heads/master@{#403028}
TBR=reveman@chromium.org,oshima@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=b/29625835, b/29229887
Committed: https://crrev.com/141947e2022ad00f7e947cdeea8204a1617b074f
Cr-Commit-Position: refs/heads/master@{#403061}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|