Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2110893003: Merge webkit_patch and multi_command_tool. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge webkit_patch and multi_command_tool. Since there is only one sub-class for MultiCommandTool, and we don't plan on adding any more, removing MultiCommandTool simplifies the code and makes it clearer that there's no more multi-command tools besides webkit-patch. This CL also updates the test accordingly -- some of the test methods in multi_command_tool_unittest.py are not relevant if there's no general MultiCommandTool superclass, so some test methods were removed. BUG=621181 Committed: https://crrev.com/cb0ae443eb2805ad5ec09ff10f6488798d8ca421 Cr-Commit-Position: refs/heads/master@{#403615}

Patch Set 1 #

Patch Set 2 : Replace copyright header in new file with new header #

Total comments: 4

Patch Set 3 : Re-add version check import; use super(); re-add name method. #

Patch Set 4 : Sort imports; remove out-of-date comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -313 lines) Patch
M third_party/WebKit/Tools/Scripts/webkit-patch View 1 2 3 3 chunks +5 lines, -8 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool.py View 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool_unittest.py View 1 chunk +0 lines, -150 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py View 1 2 3 3 chunks +97 lines, -25 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch_unittest.py View 1 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
qyearsley
4 years, 5 months ago (2016-06-30 00:04:47 UTC) #2
Dirk Pranke
lgtm w/ a couple of nits. https://codereview.chromium.org/2110893003/diff/20001/third_party/WebKit/Tools/Scripts/webkit-patch File third_party/WebKit/Tools/Scripts/webkit-patch (left): https://codereview.chromium.org/2110893003/diff/20001/third_party/WebKit/Tools/Scripts/webkit-patch#oldcode41 third_party/WebKit/Tools/Scripts/webkit-patch:41: import webkitpy.common.version_check This ...
4 years, 5 months ago (2016-07-01 22:55:42 UTC) #3
qyearsley
https://codereview.chromium.org/2110893003/diff/20001/third_party/WebKit/Tools/Scripts/webkit-patch File third_party/WebKit/Tools/Scripts/webkit-patch (left): https://codereview.chromium.org/2110893003/diff/20001/third_party/WebKit/Tools/Scripts/webkit-patch#oldcode41 third_party/WebKit/Tools/Scripts/webkit-patch:41: import webkitpy.common.version_check On 2016/07/01 at 22:55:42, Dirk Pranke wrote: ...
4 years, 5 months ago (2016-07-02 17:26:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110893003/60001
4 years, 5 months ago (2016-07-02 17:26:54 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-02 18:43:18 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-02 18:43:21 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-02 18:45:10 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cb0ae443eb2805ad5ec09ff10f6488798d8ca421
Cr-Commit-Position: refs/heads/master@{#403615}

Powered by Google App Engine
This is Rietveld 408576698