Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1628)

Issue 2110893002: [Layout API] Use LayoutViewItem in PaintPropertyTreeBuilderTest.cpp (Closed)

Created:
4 years, 5 months ago by pilgrim_google
Modified:
4 years, 5 months ago
Reviewers:
eae, jsbell
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Use LayoutViewItem in PaintPropertyTreeBuilderTest.cpp There are two instances of document().layoutView(), which is deprecated. I changed each to layoutViewItem() and added a method on LayoutItem to proxy to the relevant method on LayoutObject. There are no functional changes. BUG=499321 Committed: https://crrev.com/0af422d25ebf17ba296079e3e0192542de070b73 Cr-Commit-Position: refs/heads/master@{#402948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M third_party/WebKit/Source/core/layout/api/LayoutItem.h View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pilgrim_google
4 years, 5 months ago (2016-06-29 19:57:08 UTC) #2
eae
LGTM
4 years, 5 months ago (2016-06-29 19:58:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110893002/1
4 years, 5 months ago (2016-06-29 20:03:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 22:19:00 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 22:19:12 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 22:22:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0af422d25ebf17ba296079e3e0192542de070b73
Cr-Commit-Position: refs/heads/master@{#402948}

Powered by Google App Engine
This is Rietveld 408576698