Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2110833005: Revert of Reland "Replace ICU with CED for auto encoding detection" (Closed)

Created:
4 years, 5 months ago by Pete Williamson
Modified:
4 years, 5 months ago
Reviewers:
tkent, Jinsuk Kim
CC:
aelias_OOO_until_Jul13, blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland "Replace ICU with CED for auto encoding detection" (patchset #1 id:1 of https://codereview.chromium.org/2105263002/ ) Reason for revert: Sheriff is reverting this patchset on suspicion of adding a new static constructor (string) causing a failure of the "sizes" step of the build. Link to broken build: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21618 Relevant log lines: FAILED linux-release-64/sizes/chrome-si/initializers: actual 9, expected 7, better lower We think this is ultimately coming from encodings.cc which is part of the third party ced package, and might be related to this DEPS roll. revert_cq: 1 revert_reason_textarea: A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2110853002/ by petewil@chromium.org. The reason for reverting is: Sheriff is reverting this patchset on suspicion of adding a new static constructor (string) causing a failure of the "sizes" step of the build. Link to broken build: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21618 Relevant log lines: FAILED linux-release-64/sizes/chrome-si/initializers: actual 9, expected 7, better lower We think this is ultimately coming from encodings.cc which is part of the third party ced package, and might be related to this DEPS roll. Original issue's description: > Reland "Replace ICU with CED for auto encoding detection" > > The patch was reverted due to broken build on Windows 8 gyp. > gyp build was missing a compiler option suppressing a warning > message while gn build already handles it. crrev.com/2103793005 > now fixed the issue. > > This reverts commit e6ea446fa4e5628f61f35e5fe88e40cbb0d0b924. > > BUG=597488 > > Committed: https://crrev.com/0c155762b0654045ed3031e5d1e2b447e40ca42e > Cr-Commit-Position: refs/heads/master@{#402832} TBR=tkent@chromium.org,jinsukkim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=597488 Committed: https://crrev.com/dbd9f219ef9b615d9e116964e46b1a390c9354a1 Cr-Commit-Position: refs/heads/master@{#402901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -16 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/TextEncodingDetector.cpp View 2 chunks +69 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Pete Williamson
Created Revert of Reland "Replace ICU with CED for auto encoding detection"
4 years, 5 months ago (2016-06-29 19:34:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110833005/1
4 years, 5 months ago (2016-06-29 19:36:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 19:37:59 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 19:38:17 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dbd9f219ef9b615d9e116964e46b1a390c9354a1 Cr-Commit-Position: refs/heads/master@{#402901}
4 years, 5 months ago (2016-06-29 19:40:46 UTC) #8
tkent
4 years, 5 months ago (2016-06-29 22:45:34 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698