Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: third_party/WebKit/Source/modules/budget/NavigatorBudget.h

Issue 2110833002: Basic framework for Budget API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated to (almost) match the spec Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef NavigatorBudget_h
6 #define NavigatorBudget_h
7
8 #include "platform/Supplementable.h"
9
10 namespace blink {
11
12 class Budget;
13 class Navigator;
14
15 // This exposes the budget object on the Navigator partial interface.
16 class NavigatorBudget final :
17 public GarbageCollectedFinalized<NavigatorBudget>,
Peter Beverloo 2016/08/03 13:25:55 nit: drop the "Finalized" and remove the destructo
harkness 2016/08/04 14:18:23 Done.
18 public Supplement<Navigator> {
19 USING_GARBAGE_COLLECTED_MIXIN(NavigatorBudget);
20 WTF_MAKE_NONCOPYABLE(NavigatorBudget);
21
22 public:
23 virtual ~NavigatorBudget();
24 static NavigatorBudget& from(Navigator&);
25
26 static Budget* budget(Navigator&);
27 Budget* budget();
28
29 DECLARE_VIRTUAL_TRACE();
30
31 private:
32 explicit NavigatorBudget(Navigator*);
33 static const char* supplementName();
34
35 Member<Navigator> m_navigator;
Peter Beverloo 2016/08/03 13:25:55 Why do you store |m_navigator| here?
harkness 2016/08/04 14:18:23 Discussed in person, removing it.
36 Member<Budget> m_budget;
37 };
38
39 } // namespace blink
40
41 #endif // NavigatorBudget_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698