third_party/WebKit/Source/modules/budget/Budget.idl - Issue 2110833002: Basic framework for Budget API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/budget/Budget.idl

Issue 2110833002: Basic framework for Budget API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated to (almost) match the spec Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/budget/Budget.cpp ('K') | « third_party/WebKit/Source/modules/budget/Budget.cpp ('k') | third_party/WebKit/Source/modules/budget/BudgetChunk.idl » ('j') | third_party/WebKit/Source/modules/budget/BudgetChunk.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://beverloo.github.io/budget-api/
	Peter Beverloo 2016/08/03 13:25:54 # https://beverloo.github.io/budget-api/#budget-se # https://beverloo.github.io/budget-api/#budget-service-interface Peter Beverloo 2016/08/03 13:25:54 nit: Add a TODO for linking to a WICG spec when it nit: Add a TODO for linking to a WICG spec when it exists? harkness 2016/08/04 14:18:23 Done. Show quoted text On 2016/08/03 13:25:54, Peter Beverloo wrote: > nit: Add a TODO for linking to a WICG spec when it exists? Done. harkness 2016/08/04 14:18:23 Done. Show quoted text On 2016/08/03 13:25:54, Peter Beverloo wrote: > # https://beverloo.github.io/budget-api/#budget-service-interface Done.
	6

	7 enum ActionType {

	8 "silent-push"

	9 };

	10

	11 [

	12 Exposed=(Window, ServiceWorker),
	Peter Beverloo 2016/08/03 13:25:55 The spec says [Exposed=(Window,Worker)], you use W The spec says [Exposed=(Window,Worker)], you use Worker -> ServiceWorker. Any particular reason? harkness 2016/08/04 14:18:23 This was here from an earlier version, and I wasn' Show quoted text On 2016/08/03 13:25:55, Peter Beverloo wrote: > The spec says [Exposed=(Window,Worker)], you use Worker -> ServiceWorker. Any > particular reason? This was here from an earlier version, and I wasn't sure about Worker or ServiceWorker. Changed now.
	13 RuntimeEnabled=Budget

	14 ] interface Budget {
	Peter Beverloo 2016/08/03 13:25:55 Something to consider: The spec calls this BudgetS Something to consider: The spec calls this BudgetService, you call this Budget. One should change. Preferences? harkness 2016/08/04 14:18:23 When we were talking the other day, I suggested Bu Show quoted text On 2016/08/03 13:25:55, Peter Beverloo wrote: > Something to consider: The spec calls this BudgetService, you call this Budget. > One should change. Preferences? When we were talking the other day, I suggested BudgetService, but it seemed that consensus was for just Budget. Have you gotten any feedback about this naming on the spec? For this CL, I'm going to leave it as Budget. I can change it if we decide to.
	15 [CallWith=ScriptState] Promise<double> getCost(ActionType actionType);

	16 [CallWith=ScriptState, RaisesException] Promise<FrozenArray<BudgetChunk>> ge tBudget();

	17 };

OLD	NEW