third_party/WebKit/LayoutTests/http/tests/budget/interfaces.html - Issue 2110833002: Basic framework for Budget API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/budget/interfaces.html

Issue 2110833002: Basic framework for Budget API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Integrated code review comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title>Budget API: Verifies that the right Budget API interfaces get exposed .</title>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

	7 <script src="../serviceworker/resources/test-helpers.js"></script>
	Peter Beverloo 2016/07/22 12:27:01 What are you using from this file? What are you using from this file? harkness 2016/08/03 09:34:05 Removed. Show quoted text On 2016/07/22 12:27:01, Peter Beverloo wrote: > What are you using from this file? Removed.
	8 </head>

	9 <body>

	10 <script>

	11 test(function() {
	Peter Beverloo 2016/07/22 12:27:01 Please use promise_test. Right now, your test wil Please use promise_test. Right now, your test will pass even if the promii are settled with something other than the NotSupportedError rejection because the end of the test's control flow will be reached before the promii settle, which is done through a microtask. harkness 2016/08/03 09:34:05 Done. Show quoted text On 2016/07/22 12:27:01, Peter Beverloo wrote: > Please use promise_test. > > Right now, your test will pass even if the promii are settled with something > other than the NotSupportedError rejection because the end of the test's control > flow will be reached before the promii settle, which is done through a > microtask. Done.
	12 assert_own_property(Navigator.prototype, 'getCost');

	13 assert_own_property(Navigator.prototype, 'getBudget');

	14 assert_own_property(Navigator.prototype, 'getBudgetDetails');

	15

	16 navigator.getCost()

	17 .then(function(cost) {

	18 assert_unreached('getCost should have failed.');

	19 }, function(error) {

	20 assert_equals(error.name, 'NotSupportedError');

	21 assert_equals(error.message, 'Not yet implemented');

	22 });

	23 navigator.getBudget()

	24 .then(function(cost) {

	25 assert_unreached('getBudget should have failed.');

	26 }, function(error) {

	27 assert_equals(error.name, 'NotSupportedError');

	28 assert_equals(error.message, 'Not yet implemented');

	29 });

	30 navigator.getBudgetDetails()

	31 .then(function(cost) {

	32 assert_unreached('getBudgetDetails should have failed.');

	33 }, function(error) {

	34 assert_equals(error.name, 'NotSupportedError');

	35 assert_equals(error.message, 'Not yet implemented');

	36 });

	37 }, 'NavigatorBudget should be exposed and have the expected interface in a Document.');

	38 </script>

	39 </body>

	40 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/budget/BudgetChunk.idl » ('j') | third_party/WebKit/Source/modules/budget/BudgetChunk.idl » ('J')