third_party/WebKit/Source/modules/budget_service/NavigatorBudget.idl - Issue 2110833002: Basic framework for Budget API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/budget_service/NavigatorBudget.idl

Issue 2110833002: Basic framework for Budget API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added BudgetChunk.idl Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // TODO(harkness) Add reference to W3C standard doc.

	6

	7 enum ActionType {

	8 "silent-push"

	9 };

	10 [
	Peter Beverloo 2016/07/01 13:21:59 nit: blank line before this nit: blank line before this harkness 2016/07/20 09:41:48 Done. Show quoted text On 2016/07/01 13:21:59, Peter Beverloo wrote: > nit: blank line before this Done.
	11 RuntimeEnabled=BudgetService

	12 ] partial interface Navigator {

	13 [CallWith=ScriptState] Promise<double> getCost(ActionType actionType);

	14 [CallWith=ScriptState, RaisesException] Promise<double> getBudget();

	15 [CallWith=ScriptState, RaisesException] Promise<FrozenArray<BudgetChunk>> ge tBudgetDetails();
	Peter Beverloo 2016/07/01 13:21:59 Why do you annotate getBudget() and getBudgetDetai Why do you annotate getBudget() and getBudgetDetails() with RaisesException when they don't actually raise an exception? :) harkness 2016/07/20 09:41:48 I assumed that they would eventually, an in fact t Show quoted text On 2016/07/01 13:21:59, Peter Beverloo wrote: > Why do you annotate getBudget() and getBudgetDetails() with RaisesException when > they don't actually raise an exception? :) I assumed that they would eventually, an in fact they do now!
	16 };

OLD	NEW