third_party/WebKit/Source/modules/budget_service/BudgetChunk.idl - Issue 2110833002: Basic framework for Budget API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/budget_service/BudgetChunk.idl

Issue 2110833002: Basic framework for Budget API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added BudgetChunk.idl Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/budget_service/interfaces.html ('K') | « third_party/WebKit/LayoutTests/http/tests/budget_service/interfaces.html ('k') | third_party/WebKit/Source/modules/budget_service/NavigatorBudget.h » ('j') | third_party/WebKit/Source/modules/budget_service/NavigatorBudget.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module arc.mojom;	5 // TODO(harkness) Add reference to W3C standard doc.

6	6

7 struct ArcBitmap {	7 dictionary BudgetChunk {

8 uint32 width;	8 double budget_amount;
	Peter Beverloo 2016/07/01 13:21:59 Let's call this `budget` or `amount`. There is a Let's call this `budget` or `amount`. There is a strong preference for having short names. The fact that this will be returned from a method called getBudget() already implies that it's about budget, so I'd opt for `amount`. In addition, things in JavaScript land are named using camelCase, not hacker_style. harkness* 2016/07/20 09:41:48 Done. Show quoted text On 2016/07/01 13:21:59, Peter Beverloo wrote: > Let's call this `budget` or `amount`. > > There is a strong preference for having short names. The fact that this will > be returned from a method called get*Budget() already implies that it's about > budget, so I'd opt for `amount`. > > In addition, things in JavaScript land are named using camelCase, not > hacker_style. Done.
9 uint32 height;	9 double expiration_timestamp;
	Peter Beverloo 2016/07/01 13:21:59 `expiration`? `expiration`? harkness 2016/07/20 09:41:48 Done. Show quoted text On 2016/07/01 13:21:59, Peter Beverloo wrote: > `expiration`? Done.
10 array<uint8> pixel_data; // Must be ARGB_8888

11 };	10 };

OLD	NEW