third_party/WebKit/LayoutTests/http/tests/budget_service/interfaces.html - Issue 2110833002: Basic framework for Budget API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/budget_service/interfaces.html

Issue 2110833002: Basic framework for Budget API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added BudgetChunk.idl Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/budget_service/BudgetChunk.idl » ('j') | third_party/WebKit/Source/modules/budget_service/BudgetChunk.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title>Budget API: Verifies that the right Budget API interfaces get exposed .</title>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

	7 <script src="../serviceworker/resources/test-helpers.js"></script>

	8 </head>

	9 <body>

	10 <script>

	11 test(function() {

	12 assert_own_property(Navigator.prototype, 'getCost');

	13 assert_own_property(Navigator.prototype, 'getBudget');

	14 assert_own_property(Navigator.prototype, 'getBudgetDetails');
	Peter Beverloo 2016/07/01 13:21:59 nit: You could reject the promises for now rather nit: You could reject the promises for now rather than leaving them hanging, allowing you to test a wee bit more of the behaviour. ===== return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(NotSupportedError, "Not yet implemented.")); ===== (Allows you to remove the separate Resolver/Promise/return Promise.) harkness 2016/07/20 09:41:47 Done. Show quoted text On 2016/07/01 13:21:59, Peter Beverloo wrote: > nit: You could reject the promises for now rather than leaving them hanging, > allowing you to test a wee bit more of the behaviour. > > ===== > return ScriptPromise::rejectWithDOMException(scriptState, > DOMException::create(NotSupportedError, "Not yet implemented.")); > ===== > > (Allows you to remove the separate Resolver/Promise/return Promise.) Done.
	15

	16 }, 'NavigatorBudget should be exposed and have the expected interface in a Document.');

	17 </script>

	18 </body>

	19 </html>

OLD	NEW