Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 2110813003: Move all the AtomicString table into AtomicStringTable. (Closed)

Created:
4 years, 5 months ago by esprehn
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move all the AtomicString hash logic into AtomicStringTable. This makes the code more clear by separating it from AtomicString itself. It will also allow us to do some clever things like storing a reference to the table in the PerIsolateData and skipping the TLS lookups in the bindings. Committed: https://crrev.com/ef596a22eb27ec50b348c01684a6cf3940bca560 Cr-Commit-Position: refs/heads/master@{#403066}

Patch Set 1 #

Patch Set 2 : Fix AtomicStringCF.cpp. #

Total comments: 1

Patch Set 3 : fix comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -372 lines) Patch
M third_party/WebKit/Source/core/CoreInitializer.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/WTFThreadData.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/WTFThreadData.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicString.h View 5 chunks +14 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicString.cpp View 2 chunks +25 lines, -311 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicStringCF.cpp View 1 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicStringTable.h View 1 2 2 chunks +40 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp View 3 chunks +296 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110813003/1
4 years, 5 months ago (2016-06-29 21:49:20 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/96205) mac_chromium_compile_dbg_ng on ...
4 years, 5 months ago (2016-06-29 22:09:04 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110813003/20001
4 years, 5 months ago (2016-06-29 23:00:09 UTC) #6
esprehn
4 years, 5 months ago (2016-06-29 23:43:05 UTC) #9
haraken
LGTM https://codereview.chromium.org/2110813003/diff/20001/third_party/WebKit/Source/wtf/text/AtomicStringTable.h File third_party/WebKit/Source/wtf/text/AtomicStringTable.h (right): https://codereview.chromium.org/2110813003/diff/20001/third_party/WebKit/Source/wtf/text/AtomicStringTable.h#newcode53 third_party/WebKit/Source/wtf/text/AtomicStringTable.h:53: // Froming a StringImpl. This is for ~StringImpl, ...
4 years, 5 months ago (2016-06-29 23:50:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110813003/40001
4 years, 5 months ago (2016-06-29 23:54:29 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 02:17:19 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 02:19:15 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ef596a22eb27ec50b348c01684a6cf3940bca560
Cr-Commit-Position: refs/heads/master@{#403066}

Powered by Google App Engine
This is Rietveld 408576698