Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2110803004: Switch WebGL 1.0 conformance tests to new GPU integration test harness. (Closed)

Created:
4 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Geoff Lang, Corentin Wallez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch WebGL 1.0 conformance tests to new GPU integration test harness. This will allow these tests to be sharded and improve flaky test handling. BUG=352807, 622948 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6ab8b3bc2f12e0d4a2857f303bbbae1395c37fd2 Cr-Commit-Position: refs/heads/master@{#403240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -148 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 2 chunks +6 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 9 chunks +18 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 62 chunks +124 lines, -124 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Ken Russell (switch to Gerrit)
zmo, jmadill: please review. Thanks.
4 years, 5 months ago (2016-06-30 02:57:30 UTC) #5
Zhenyao Mo
lgtm This is great
4 years, 5 months ago (2016-06-30 03:49:11 UTC) #6
Ken Russell (switch to Gerrit)
The dry run failures are unrelated. Going to try landing this.
4 years, 5 months ago (2016-06-30 17:27:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110803004/1
4 years, 5 months ago (2016-06-30 17:27:52 UTC) #9
Jamie Madill
lgtm, that's great. don't know the new harness too well, so will trust mo and ...
4 years, 5 months ago (2016-06-30 17:30:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 19:08:46 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 19:09:01 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6ab8b3bc2f12e0d4a2857f303bbbae1395c37fd2 Cr-Commit-Position: refs/heads/master@{#403240}
4 years, 5 months ago (2016-06-30 19:10:51 UTC) #15
ynovikov
I have a suspicion this broke GPU.FYI and ANGLE CQ
4 years, 5 months ago (2016-07-02 00:15:11 UTC) #16
Ken Russell (switch to Gerrit)
4 years, 5 months ago (2016-07-02 03:36:01 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2120043002/ by kbr@chromium.org.

The reason for reverting is: Broke Android bots on chromium.gpu.fyi per
ynovikov@'s comment above; see http://crbug.com/622948 .
.

Powered by Google App Engine
This is Rietveld 408576698