Issue 21108004: Separate ScrollbarThemeMac into separate files

Issue 21108004: Separate ScrollbarThemeMac into separate files (Closed)

Created:
7 years, 4 months ago by ccameron

Modified:
7 years, 4 months ago

Reviewers:
enne (OOO)

CC:
blink-reviews, jeez, dglazkov+blink, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@second_refactor

Visibility:
Public.

More Reviews

Description

Separate ScrollbarThemeMac into separate files This is the second of two steps. The first separated the classes and methods. This is a purely mechanical change that breaks ScrollbarThemeMac.mm and ScrollbarThemeMac.h into separate files for Common, Overlay, and NonOverlay BUG=133093 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155357

Patch Set 1 #

Patch Set 2 : Incorporate review feedback #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+586 lines, -536 lines)			Patch
M	Source/core/core.gyp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/core.gypi	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/platform/mac/ScrollAnimatorMac.mm	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/platform/mac/ScrollbarThemeMac.h	View	1	2 chunks	+0 lines, -51 lines	0 comments	Download
M	Source/core/platform/mac/ScrollbarThemeMac.mm	View	1	8 chunks	+2 lines, -447 lines	0 comments	Download
A +	Source/core/platform/mac/ScrollbarThemeMacNonOverlayAPI.h	View	1	1 chunk	+16 lines, -26 lines	0 comments	Download
A	Source/core/platform/mac/ScrollbarThemeMacNonOverlayAPI.mm	View	1	1 chunk	+336 lines, -0 lines	0 comments	Download
A +	Source/core/platform/mac/ScrollbarThemeMacOverlayAPI.h	View	1	2 chunks	+29 lines, -12 lines	0 comments	Download
A	Source/core/platform/mac/ScrollbarThemeMacOverlayAPI.mm	View	1	1 chunk	+196 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

ccameron

This is the (sinister) part two of https://codereview.chromium.org/21296003/

7 years, 4 months ago (2013-07-31 02:10:41 UTC) #1

enne (OOO)

The new files are missing a license: http://www.chromium.org/blink/coding-style#TOC-License

7 years, 4 months ago (2013-07-31 17:42:46 UTC) #2

ccameron

Added the copyrights & resolved against the previous changes.

7 years, 4 months ago (2013-08-01 00:31:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/21108004/6001

7 years, 4 months ago (2013-08-01 17:26:09 UTC) #6

commit-bot: I haz the power

Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=868

7 years, 4 months ago (2013-08-01 20:23:42 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/21108004/6001

7 years, 4 months ago (2013-08-01 20:51:36 UTC) #8

Message was sent while issue was closed.

Change committed as 155357

Expand Messages | Collapse Messages