third_party/WebKit/Source/core/html/forms/ColorInputType.cpp - Issue 2110783002: Open a color input with display:none via a label

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

Issue 2110783002: Open a color input with display:none via a label (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated test case as per review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

index 3dd217acfd75aa5dfe7a994dca9ae9476ac6e6a8..66b9327d052b4ebc99e34f1738484b444ec8ceeb 100644

--- a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

@@ -167,7 +167,7 @@ void ColorInputType::setValue(const String& value, bool valueChanged, TextFieldE

void ColorInputType::handleDOMActivateEvent(Event* event)

{

- if (element().isDisabledFormControl() || !element().layoutObject())

+ if (element().isDisabledFormControl())

return;

if (!UserGestureIndicator::utilizeUserGesture())

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/color/display-none-input-color-chooser-shown.html ('k') | no next file » | no next file with comments »