third_party/WebKit/LayoutTests/fast/forms/color/display-none-input-color-chooser-shown.html - Issue 2110783002: Open a color input with display:none via a label

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/color/display-none-input-color-chooser-shown.html

Issue 2110783002: Open a color input with display:none via a label (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated testcase to include closure of popup when parent is removed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <div id="host">

	5 <input id="colorPick" type="color" />

	6 <label for="colorPick" id="labelPick">Pick a color</label>

	7 </div>

	8 <script>

	9 test (function() {

	10 assert_true(window.eventSender !== null);

	11 }, "window.eventSender is required for the test to run");

	12

	13 test (function() {

	14 var colorPicker = document.getElementById("colorPick");

	15 colorPicker.style.display = "none";

	16 var labelPick = document.getElementById("labelPick");

	17 var x = labelPick.offsetLeft + labelPick.offsetWidth/2;

	18 var y = labelPick.offsetTop + labelPick.offsetHeight/2;

	19 eventSender.mouseMoveTo(x, y);

	20 eventSender.mouseDown();

	21 eventSender.mouseUp();

	22 assert_true(testRunner.isChooserShown());

	23

	24 var div = document.getElementById('host');

	25 document.body.removeChild(div);
	tkent 2016/07/01 06:54:08 In this case, HTMLInputElement::removedFrom() is c In this case, HTMLInputElement::removedFrom() is called. So the picker is closed by InputTypeView::closePopupView(). I talked about a case of a document destruction, which won't call HTMLInputElement::removedFrom(). ramya.v 2016/07/01 09:14:45 Can you please provide a test case of document des Show quoted text On 2016/07/01 06:54:08, tkent wrote: > In this case, HTMLInputElement::removedFrom() is called. So the picker is > closed by InputTypeView::closePopupView(). > > I talked about a case of a document destruction, which won't call > HTMLInputElement::removedFrom(). Can you please provide a test case of document destruction? Will check if closePopup can be called from document destruction code path as well. Also one more doubt, is there any specific reason that file input and color input handled differently in case of display none case? tkent 2016/07/01 09:23:28 for example, 1. click a label associated to input Show quoted text On 2016/07/01 at 09:14:45, ramya.v wrote: > On 2016/07/01 06:54:08, tkent wrote: > > In this case, HTMLInputElement::removedFrom() is called. So the picker is > > closed by InputTypeView::closePopupView(). > > > > I talked about a case of a document destruction, which won't call > > HTMLInputElement::removedFrom(). > > > Can you please provide a test case of document destruction? Will check if closePopup can be called from document destruction code path as well. > Also one more doubt, is there any specific reason that file input and color input handled differently in case of display none case? for example, 1. click a label associated to input[type=color] with display:none 2. click a link in the same document to navigate to another page. Picker implementations of input[type=color] and input[type=file] are very different. So I have a concern. ramya.v 2016/07/01 10:05:50 Made below test case. <!DOCTYPE html> <input type Show quoted text On 2016/07/01 09:23:28, tkent wrote: > On 2016/07/01 at 09:14:45, ramya.v wrote: > > On 2016/07/01 06:54:08, tkent wrote: > > > In this case, HTMLInputElement::removedFrom() is called. So the picker is > > > closed by InputTypeView::closePopupView(). > > > > > > I talked about a case of a document destruction, which won't call > > > HTMLInputElement::removedFrom(). > > > > > > Can you please provide a test case of document destruction? Will check if > closePopup can be called from document destruction code path as well. > > Also one more doubt, is there any specific reason that file input and color > input handled differently in case of display none case? > > for example, > 1. click a label associated to input[type=color] with display:none > 2. click a link in the same document to navigate to another page. > > Picker implementations of input[type=color] and input[type=file] are very > different. So I have a concern. Made below test case. <!DOCTYPE html> <input type="color" id="colorPick" /> <label for="colorPick">Pick a color</label> <a id="link" href="http://www.google.com">Google</a> <style> input { display: none; } </style> <script> setTimeout(function() { document.getElementById("link").click(); }, 5000); </script> In this case, irrespective of color picker opened with input display none or not, Firefox: picker not dismissed. Chrome: Windows : picker is not dismissed. Linux: picker is dismissed. I've linux opensource setup. There call-stack is as below in this case. ColorInputType::closePopupView ContainerNode::detach() Element::detach() ContainerNode::detach() Element::detach() ContainerNode::detach() Document::detach() FrameLoader::prepareForCommit() tkent 2016/07/04 01:25:59 Thank you for the investigation. So, this CL won' Show quoted text On 2016/07/01 at 10:05:50, ramya.v wrote: > In this case, irrespective of color picker opened with input display none or not, > Firefox: picker not dismissed. > Chrome: > Windows : picker is not dismissed. > Linux: picker is dismissed. Thank you for the investigation. So, this CL won't make the situation worse. LGTM. BTW, would you file a bug about this scenario please? ramya.v 2016/07/04 04:47:56 Filed a bug in crbug.com/625525. Done. Show quoted text On 2016/07/04 01:25:59, tkent wrote: > On 2016/07/01 at 10:05:50, ramya.v wrote: > > In this case, irrespective of color picker opened with input display none or > not, > > Firefox: picker not dismissed. > > Chrome: > > Windows : picker is not dismissed. > > Linux: picker is dismissed. > > Thank you for the investigation. So, this CL won't make the situation worse. > LGTM. > BTW, would you file a bug about this scenario please? Filed a bug in crbug.com/625525. Done.
	26 setTimeout(function() { assert_false(testRunner.isChooserShown()); }, 5000);
	tkent 2016/07/01 06:54:08 This doesn't work. This is a sync test. This doesn't work. This is a sync test. ramya.v 2016/07/01 09:14:45 Did not get you? Test case shows pass. Is this li Show quoted text On 2016/07/01 06:54:08, tkent wrote: > This doesn't work. This is a sync test. Did not get you? Test case shows pass. Is this line invalid? tkent 2016/07/01 09:23:28 I didn't try this patch. But this assert_false() Show quoted text On 2016/07/01 at 09:14:45, ramya.v wrote: > On 2016/07/01 06:54:08, tkent wrote: > > This doesn't work. This is a sync test. > > Did not get you? Test case shows pass. Is this line invalid? I didn't try this patch. But this assert_false() won't be executed in run-webkit-tests command or \|content_shel --run-layout-test\|. ramya.v 2016/07/01 10:05:50 Thanks got your point :) Will remove testing this Show quoted text On 2016/07/01 09:23:28, tkent wrote: > On 2016/07/01 at 09:14:45, ramya.v wrote: > > On 2016/07/01 06:54:08, tkent wrote: > > > This doesn't work. This is a sync test. > > > > Did not get you? Test case shows pass. Is this line invalid? > > I didn't try this patch. But this assert_false() won't be executed in > run-webkit-tests command or \|content_shel --run-layout-test\|. Thanks got your point :) Will remove testing this way.
	27 }, "Tests click on label for color picker with display none should show chooser" );

	28 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/forms/ColorInputType.cpp » ('j') | no next file with comments »