Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2110743002:
Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". (Closed)
DescriptionMac: Use "esc" rather than "Esc" in "Press Esc to exit full screen".
Mac keyboards use lowercase for everything except function keys, which
are typically reserved for system use. Since |Esc| is placed in a box
specifically to make it look like a keyboard key it looks weird to not
follow suit.
Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since
the latter is used by ui::Accelerator::GetShortcutText() for other
things.
This still isn't perfect. Some macbooks use the ISO symbol for escape,
"⎋" (e.g. French Canadian). But we can't assume a user's locale setting
always determines how the keyboard looks. Using lowercase gets us pretty
close.
BUG=623636
Committed: https://crrev.com/8d54ff1f2aa0ac5bf75f5489b3bbb3d9689c014d
Cr-Commit-Position: refs/heads/master@{#403035}
Patch Set 1 #
Messages
Total messages: 14 (9 generated)
Description was changed from ========== Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since it is used by ui::Accelerator::GetShortcutText() for other things. BUG=623636 ========== to ========== Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since it is used by ui::Accelerator::GetShortcutText() for other things. BUG=623636 ==========
Description was changed from ========== Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since it is used by ui::Accelerator::GetShortcutText() for other things. BUG=623636 ========== to ========== Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since it is used by ui::Accelerator::GetShortcutText() for other things. BUG=623636 ==========
Description was changed from ========== Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since it is used by ui::Accelerator::GetShortcutText() for other things. BUG=623636 ========== to ========== Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since the later is used by ui::Accelerator::GetShortcutText() for other things. BUG=623636 ==========
tapted@chromium.org changed reviewers: + msw@chromium.org
Description was changed from ========== Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since the later is used by ui::Accelerator::GetShortcutText() for other things. BUG=623636 ========== to ========== Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since the later is used by ui::Accelerator::GetShortcutText() for other things. This still isn't perfect. Some macbooks use the ISO symbol for escape, "⎋" (e.g. French Canadian). But we can't assume a user's locale setting always determines how the keyboard looks. Using lowercase gets us pretty close. BUG=623636 ==========
Hi Mike, please take a look
lgtm
Description was changed from ========== Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since the later is used by ui::Accelerator::GetShortcutText() for other things. This still isn't perfect. Some macbooks use the ISO symbol for escape, "⎋" (e.g. French Canadian). But we can't assume a user's locale setting always determines how the keyboard looks. Using lowercase gets us pretty close. BUG=623636 ========== to ========== Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since the latter is used by ui::Accelerator::GetShortcutText() for other things. This still isn't perfect. Some macbooks use the ISO symbol for escape, "⎋" (e.g. French Canadian). But we can't assume a user's locale setting always determines how the keyboard looks. Using lowercase gets us pretty close. BUG=623636 ==========
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since the latter is used by ui::Accelerator::GetShortcutText() for other things. This still isn't perfect. Some macbooks use the ISO symbol for escape, "⎋" (e.g. French Canadian). But we can't assume a user's locale setting always determines how the keyboard looks. Using lowercase gets us pretty close. BUG=623636 ========== to ========== Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since the latter is used by ui::Accelerator::GetShortcutText() for other things. This still isn't perfect. Some macbooks use the ISO symbol for escape, "⎋" (e.g. French Canadian). But we can't assume a user's locale setting always determines how the keyboard looks. Using lowercase gets us pretty close. BUG=623636 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since the latter is used by ui::Accelerator::GetShortcutText() for other things. This still isn't perfect. Some macbooks use the ISO symbol for escape, "⎋" (e.g. French Canadian). But we can't assume a user's locale setting always determines how the keyboard looks. Using lowercase gets us pretty close. BUG=623636 ========== to ========== Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since the latter is used by ui::Accelerator::GetShortcutText() for other things. This still isn't perfect. Some macbooks use the ISO symbol for escape, "⎋" (e.g. French Canadian). But we can't assume a user's locale setting always determines how the keyboard looks. Using lowercase gets us pretty close. BUG=623636 Committed: https://crrev.com/8d54ff1f2aa0ac5bf75f5489b3bbb3d9689c014d Cr-Commit-Position: refs/heads/master@{#403035} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8d54ff1f2aa0ac5bf75f5489b3bbb3d9689c014d Cr-Commit-Position: refs/heads/master@{#403035} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
