SoM: Navbar links++

SoM: Navbar links++

BUG=619184
Committed: https://chromium.googlesource.com/infra/infra/+/6123409e813e9cf97c18a9e18bfe3715221ad5de

[Tiff, 2016-06-29 23:40:52]

zhangtiff@google.com changed reviewers:
+ martiniss@chromium.org

[Tiff, 2016-06-29 23:40:53]

PTAL

Did the sidebar change plus some small housekeeping things like alphabetizing
some of the CSS and adding my email to the CC field for filing a bug.

[martiniss, 2016-06-30 00:40:15]

martiniss@chromium.org changed reviewers:
+ jparent@chromium.org

[martiniss, 2016-06-30 00:40:16]

Julie, have anything you think should go on the help page?

https://codereview.chromium.org/2110723004/diff/1/go/src/infra/appengine/sher...
File go/src/infra/appengine/sheriff-o-matic/elements/pages/som-help.html
(right):

https://codereview.chromium.org/2110723004/diff/1/go/src/infra/appengine/sher...
go/src/infra/appengine/sheriff-o-matic/elements/pages/som-help.html:32: <a
href="https://code.google.com/p/chromium/wiki/UsefulURLs" target="_blank">Useful
URLs</a>
This doesn't really point to anything.... Remove I guess? :/

https://codereview.chromium.org/2110723004/diff/1/go/src/infra/appengine/sher...
go/src/infra/appengine/sheriff-o-matic/elements/pages/som-help.html:38: <a
href="https://sites.google.com/a/chromium.org/dev/developers/testing/contacting-a-trooper"
target="_blank">How to contact a Trooper</a>
Just make this point to g.co/bugatrooper

https://codereview.chromium.org/2110723004/diff/1/go/src/infra/appengine/sher...
File go/src/infra/appengine/sheriff-o-matic/elements/som-app.html (left):

https://codereview.chromium.org/2110723004/diff/1/go/src/infra/appengine/sher...
go/src/infra/appengine/sheriff-o-matic/elements/som-app.html:353:
console.error('error: pathParts < 2', pathParts);
Why'd the semi-colon go away?

[Tiff, 2016-06-30 00:44:16]

Changes made.

https://codereview.chromium.org/2110723004/diff/1/go/src/infra/appengine/sher...
File go/src/infra/appengine/sheriff-o-matic/elements/pages/som-help.html
(right):

https://codereview.chromium.org/2110723004/diff/1/go/src/infra/appengine/sher...
go/src/infra/appengine/sheriff-o-matic/elements/pages/som-help.html:32: <a
href="https://code.google.com/p/chromium/wiki/UsefulURLs" target="_blank">Useful
URLs</a>
On 2016/06/30 at 00:40:15, martiniss wrote:
> This doesn't really point to anything.... Remove I guess? :/

Done.

https://codereview.chromium.org/2110723004/diff/1/go/src/infra/appengine/sher...
go/src/infra/appengine/sheriff-o-matic/elements/pages/som-help.html:38: <a
href="https://sites.google.com/a/chromium.org/dev/developers/testing/contacting-a-trooper"
target="_blank">How to contact a Trooper</a>
On 2016/06/30 at 00:40:15, martiniss wrote:
> Just make this point to g.co/bugatrooper

Done.

https://codereview.chromium.org/2110723004/diff/1/go/src/infra/appengine/sher...
File go/src/infra/appengine/sheriff-o-matic/elements/som-app.html (left):

https://codereview.chromium.org/2110723004/diff/1/go/src/infra/appengine/sher...
go/src/infra/appengine/sheriff-o-matic/elements/som-app.html:353:
console.error('error: pathParts < 2', pathParts);
On 2016/06/30 at 00:40:15, martiniss wrote:
> Why'd the semi-colon go away?

Oops, this was a mistake! Thanks! :D

[jparent, 2016-06-30 01:02:45]

jparent@google.com changed reviewers:
+ jparent@google.com

[jparent, 2016-06-30 01:02:46]

Nothing specific from my end, as long as everything that was in the previous
help section is still there.  We can definitely beef this up in the future.

[martiniss, 2016-06-30 01:05:49]

martiniss@chromium.org changed reviewers:
- jparent@google.com

[martiniss, 2016-06-30 01:05:49]

great. lgtm !

https://codereview.chromium.org/2110723004/diff/1/go/src/infra/appengine/sher...
File go/src/infra/appengine/sheriff-o-matic/elements/som-drawer.html (right):

https://codereview.chromium.org/2110723004/diff/1/go/src/infra/appengine/sher...
go/src/infra/appengine/sheriff-o-matic/elements/som-drawer.html:98: for (let key
in staticPages) {
I feel like there must be a better way to flatten an object into a list :/

[Tiff, 2016-06-30 01:08:17]

The CQ bit was checked by zhangtiff@google.com

[commit-bot: I haz the power, 2016-06-30 01:08:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 01:22:27]

Description was changed from

==========
SoM: Navbar links++

BUG=61918
==========

to

==========
SoM: Navbar links++

BUG=61918

Committed:
https://chromium.googlesource.com/infra/infra/+/6123409e813e9cf97c18a9e18bfe3...
==========

[commit-bot: I haz the power, 2016-06-30 01:22:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/6123409e813e9cf97c18a9e18bfe3...

[Tiff, 2016-06-30 20:56:48]

Description was changed from

==========
SoM: Navbar links++

BUG=61918

Committed:
https://chromium.googlesource.com/infra/infra/+/6123409e813e9cf97c18a9e18bfe3...
==========

to

==========
SoM: Navbar links++

BUG=619184

Committed:
https://chromium.googlesource.com/infra/infra/+/6123409e813e9cf97c18a9e18bfe3...
==========