Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2110723002: Revert of Flip Google Chrome Mac, mac trunk to GN for testing. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip Google Chrome Mac, mac trunk to GN for testing. (patchset #1 id:1 of https://codereview.chromium.org/2104223002/ ) Reason for revert: The remoting_me2me_host fix hasn't landed, and so the compile fails before we really get to test the dump_syms fix. I'll try again tomorrow ... Original issue's description: > Flip Google Chrome Mac, mac trunk to GN for testing. > > I will revert this CL once we have a build or two for data. > > R=rsesek@chromium.org > BUG=622406 > > Committed: https://crrev.com/dde87e139b67dcdd6dcb598b35f56aca2314bd47 > Cr-Commit-Position: refs/heads/master@{#402662} TBR=rsesek@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622406 Committed: https://crrev.com/ae51ae23a9a17a5c693d60bb69db9e51d8390e24 Cr-Commit-Position: refs/heads/master@{#402718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
Created Revert of Flip Google Chrome Mac, mac trunk to GN for testing.
4 years, 5 months ago (2016-06-29 04:36:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110723002/1
4 years, 5 months ago (2016-06-29 04:37:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 04:38:01 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 04:39:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae51ae23a9a17a5c693d60bb69db9e51d8390e24
Cr-Commit-Position: refs/heads/master@{#402718}

Powered by Google App Engine
This is Rietveld 408576698