Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 21107: Stub implementation of gtk browser window. (Closed)

Created:
10 years, 6 months ago by Evan Stade
Modified:
8 years, 2 months ago
Reviewers:
tony, Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Stub implementation of gtk browser window. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9276

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -7 lines) Patch
M chrome/app/chrome_dll_main.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/browser.scons View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/browser_window_factory_gtk.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/browser_window_gtk.h View 1 chunk +64 lines, -0 lines 0 comments Download
A chrome/browser/browser_window_gtk.cc View 1 2 1 chunk +173 lines, -0 lines 0 comments Download
M chrome/common/temp_scaffolding_stubs.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Stade
I'm not too clear on the whole ownership/responsibility model between browser, browser window, etc. so ...
10 years, 6 months ago (2009-02-05 22:59:27 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/21107/diff/3001/3002 File chrome/app/chrome_dll_main.cc (right): http://codereview.chromium.org/21107/diff/3001/3002#newcode210 Line 210: #if defined(OS_LINUX) can you put a commetn ...
10 years, 6 months ago (2009-02-05 23:05:41 UTC) #2
tony
10 years, 6 months ago (2009-02-05 23:06:00 UTC) #3
LGTM, but evanm should also review.

http://codereview.chromium.org/21107/diff/1/6
File chrome/browser/browser_window_gtk.cc (right):

http://codereview.chromium.org/21107/diff/1/6#newcode18
Line 18: Close();
Is it possible for Close() to run before this destructor is called?  It looks
like that would be bad.

Powered by Google App Engine
This is Rietveld 408576698