Remove "_finished" assertion checks from summary codegen.

Remove "_finished" assertion checks from summary codegen.

These assertions were helpful back when the client manually managed
offsets.  Now that offsets are managed automatically by the toBuffer()
logic, they don't carry any benefit.

Removing these assertions will pave the way for allowing a summary to be
created, serialized, modified, and then serialized again, which we will
need to do to efficiently generate both "full" and "semantic" summaries.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/efe5a31421f04e5c9250779f7666f71fdd9ffbf3

[Paul Berry, 2016-06-28 22:30:33]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-06-28 23:20:28]

lgtm

[Paul Berry, 2016-06-28 23:23:00]

Description was changed from

==========
Remove "_finished" assertion checks from summary codegen.

These assertions were helpful back when the client manually managed
offsets.  Now that offsets are managed automatically by the toBuffer()
logic, they don't carry any benefit.

Removing these assertions will pave the way for allowing a summary to be
created, serialized, modified, and then serialized again, which we will
need to do to efficiently generate both "full" and "semantic" summaries.
==========

to

==========
Remove "_finished" assertion checks from summary codegen.

These assertions were helpful back when the client manually managed
offsets.  Now that offsets are managed automatically by the toBuffer()
logic, they don't carry any benefit.

Removing these assertions will pave the way for allowing a summary to be
created, serialized, modified, and then serialized again, which we will
need to do to efficiently generate both "full" and "semantic" summaries.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/efe5a31421f04e5c9250779f7666f71fdd9ffbf3
==========

[Paul Berry, 2016-06-28 23:23:01]

Committed patchset #1 (id:1) manually as
efe5a31421f04e5c9250779f7666f71fdd9ffbf3 (presubmit successful).