Allow benchmarks to specify running multiple metrics.

telemetry/telemetry/web_perf/timeline_based_measurement.py

Index: telemetry/telemetry/web_perf/timeline_based_measurement.py
diff --git a/telemetry/telemetry/web_perf/timeline_based_measurement.py b/telemetry/telemetry/web_perf/timeline_based_measurement.py
index 78103823d1c2511fbb3ca7af5acf280951a4e82b..e386427016ab10cc5cd68256f3e7c6193e967f9f 100644
--- a/telemetry/telemetry/web_perf/timeline_based_measurement.py
+++ b/telemetry/telemetry/web_perf/timeline_based_measurement.py
@@ -190,7 +190,7 @@ class Options(object):
                       "object or valid overhead level string. Given overhead "
                       "level: %s" % overhead_level)
 
-    self._timeline_based_metric = None
+    self._timeline_based_metrics = None
     self._legacy_timeline_based_metrics = []
 
 
@@ -208,20 +208,16 @@ class Options(object):
     return self._config
 
   def SetTimelineBasedMetric(self, metric):

[charliea (OOO until 10-5), 2016/07/06 19:52:41]

nit: are you going to delete this now that you're replacing all
SetTimelineBasedMetric calls with SetTimelineBasedMetrics([metric])?

(If so, please add a TODO to delete this method once that's done.)

(Also, FWIW, my vote is to delete this method. It doesn't seem like saving two
characters is enough of a convenience to warrant having an extra method)

[alexandermont, 2016/07/06 20:06:55]

Done

-    """Sets the new-style (TBMv2) metric to run.
+    self.SetTimelineBasedMetrics([metric])
 
-    Metrics are assumed to live in //tracing/tracing/metrics, so the path
-    should be relative to that. For example, to specify sample_metric.html,
-    you would pass 'sample_metric.html'.
+  def SetTimelineBasedMetrics(self, metrics):

[charliea (OOO until 10-5), 2016/07/06 19:52:41]

Gah - sorry, this is totally my fault. I'd leave the comment in: I didn't see
the additional context about where metrics are assumed to live and such, which
is probably useful for callers to know. 

(I just saw "Sets the new-style (TBMv2) metric to run.")

Sorry for the noise.

[alexandermont, 2016/07/06 20:06:55]

Done

+    assert isinstance(metrics, list)
+    for metric in metrics:
+      assert isinstance(metric, basestring)
+    self._timeline_based_metrics = metrics
 
-    Args:
-      metric: A string metric path under //tracing/tracing/metrics.
-    """
-    assert isinstance(metric, basestring)
-    self._timeline_based_metric = metric
-
-  def GetTimelineBasedMetric(self):
-    return self._timeline_based_metric
+  def GetTimelineBasedMetrics(self):
+    return self._timeline_based_metrics
 
   def SetLegacyTimelineBasedMetrics(self, metrics):
     assert isinstance(metrics, collections.Iterable)
@@ -279,8 +275,8 @@ class TimelineBasedMeasurement(story_test.StoryTest):
     trace_value = trace.TraceValue(results.current_page, trace_result)
     results.AddValue(trace_value)
 
-    if self._tbm_options.GetTimelineBasedMetric():
-      self._ComputeTimelineBasedMetric(results, trace_value)
+    if self._tbm_options.GetTimelineBasedMetrics():
+      self._ComputeTimelineBasedMetrics(results, trace_value)
       # Legacy metrics can be computed, but only if explicitly specified.
       if self._tbm_options.GetLegacyTimelineBasedMetrics():
         self._ComputeLegacyTimelineBasedMetrics(results, trace_result)
@@ -299,14 +295,14 @@ class TimelineBasedMeasurement(story_test.StoryTest):
     if platform.tracing_controller.is_tracing_running:
       platform.tracing_controller.StopTracing()
 
-  def _ComputeTimelineBasedMetric(self, results, trace_value):
-    metric = self._tbm_options.GetTimelineBasedMetric()
+  def _ComputeTimelineBasedMetrics(self, results, trace_value):
+    metrics = self._tbm_options.GetTimelineBasedMetrics()
     extra_import_options = {
       'trackDetailedModelStats': True
     }
 
     mre_result = metric_runner.RunMetric(
-        trace_value.filename, metric, extra_import_options)
+        trace_value.filename, metrics, extra_import_options)
     page = results.current_page
 
     failure_dicts = mre_result.failures