Use toString tag to format receiver in stack traces

Use toString tag to format receiver in stack traces

This concerns formatting of calls to, e.g., Math.acos in stack traces,
in which the receiver is an object with an attached toString tag. If
such a tag exists, use it to format the receiver typename to ensure that
the stack trace includes 'Math.acos' instead of 'Object.acos'.

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/971468031a911cd6d90524af2fce64833aeafc40
Cr-Commit-Position: refs/heads/master@{#37513}

[jgruber, 2016-06-30 10:37:15]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 10:37:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 10:55:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 10:55:27]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[jgruber, 2016-06-30 13:34:54]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 13:34:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 14:09:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 14:09:45]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-07-01 07:13:15]

Description was changed from

==========
Use toString tag to format receiver in stack traces

This concerns formatting of calls to, e.g., Math.acos in stack traces,
in which the receiver is an object with an attached toString tag. If
such a tag exists, use it to format the receiver typename to ensure that
the stack trace includes 'Math.acos' instead of 'Object.acos'.

R=yangguo@chromium.org
BUG=
==========

to

==========
Use toString tag to format receiver in stack traces

This concerns formatting of calls to, e.g., Math.acos in stack traces,
in which the receiver is an object with an attached toString tag. If
such a tag exists, use it to format the receiver typename to ensure that
the stack trace includes 'Math.acos' instead of 'Object.acos'.

R=yangguo@chromium.org
BUG=
==========

[jgruber, 2016-07-01 07:13:15]

jgruber@chromium.org changed reviewers:
+ verwaest@chromium.org

[Toon Verwaest, 2016-07-01 07:25:24]

nice, lgtm

[Yang, 2016-07-04 10:55:38]

LGTM.

https://codereview.chromium.org/2110683007/diff/20001/src/runtime/runtime-obj...
File src/runtime/runtime-object.cc (right):

https://codereview.chromium.org/2110683007/diff/20001/src/runtime/runtime-obj...
src/runtime/runtime-object.cc:767: ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate,
recv,
Can this actually throw? If it does, should we catch that and instead return
some default string?

[jgruber, 2016-07-04 12:40:19]

https://codereview.chromium.org/2110683007/diff/20001/src/runtime/runtime-obj...
File src/runtime/runtime-object.cc (right):

https://codereview.chromium.org/2110683007/diff/20001/src/runtime/runtime-obj...
src/runtime/runtime-object.cc:767: ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate,
recv,
On 2016/07/04 10:55:38, Yang wrote:
> Can this actually throw? If it does, should we catch that and instead return
> some default string?

Apparently, Object::ToObject() throws if null or undefined are passed. We ensure
this is not the case in messages.js:GetTypeName(). Added a CHECK here and
removed the ASSIGN_RETURN_FAILURE_ON_EXCEPTION use.

[jgruber, 2016-07-04 12:44:41]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-04 12:44:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 12:45:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-04 12:45:55]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/8448)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[jgruber, 2016-07-04 12:49:43]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-04 12:49:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 12:51:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-04 12:51:26]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/4400)

[jgruber, 2016-07-04 13:27:23]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-07-04 13:27:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
yangguo@chromium.org, verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2110683007/#ps60001
(title: "Rebase on master")

[commit-bot: I haz the power, 2016-07-04 13:27:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 13:29:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-04 13:29:24]

Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/4407)

[Michael Achenbach, 2016-07-05 06:47:32]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-05 06:47:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 07:12:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 07:12:33]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-07-05 07:40:17]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-07-05 07:40:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 07:42:27]

Description was changed from

==========
Use toString tag to format receiver in stack traces

This concerns formatting of calls to, e.g., Math.acos in stack traces,
in which the receiver is an object with an attached toString tag. If
such a tag exists, use it to format the receiver typename to ensure that
the stack trace includes 'Math.acos' instead of 'Object.acos'.

R=yangguo@chromium.org
BUG=
==========

to

==========
Use toString tag to format receiver in stack traces

This concerns formatting of calls to, e.g., Math.acos in stack traces,
in which the receiver is an object with an attached toString tag. If
such a tag exists, use it to format the receiver typename to ensure that
the stack trace includes 'Math.acos' instead of 'Object.acos'.

R=yangguo@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-07-05 07:42:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-05 07:43:03]

Description was changed from

==========
Use toString tag to format receiver in stack traces

This concerns formatting of calls to, e.g., Math.acos in stack traces,
in which the receiver is an object with an attached toString tag. If
such a tag exists, use it to format the receiver typename to ensure that
the stack trace includes 'Math.acos' instead of 'Object.acos'.

R=yangguo@chromium.org
BUG=
==========

to

==========
Use toString tag to format receiver in stack traces

This concerns formatting of calls to, e.g., Math.acos in stack traces,
in which the receiver is an object with an attached toString tag. If
such a tag exists, use it to format the receiver typename to ensure that
the stack trace includes 'Math.acos' instead of 'Object.acos'.

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/971468031a911cd6d90524af2fce64833aeafc40
Cr-Commit-Position: refs/heads/master@{#37513}
==========

[commit-bot: I haz the power, 2016-07-05 07:43:04]

Patchset 4 (id:??) landed as
https://crrev.com/971468031a911cd6d90524af2fce64833aeafc40
Cr-Commit-Position: refs/heads/master@{#37513}